[raster] undefined references to GDAL library

[strk]

raster/loader/raster2pgsql.c:695: undefined reference to `GDALOpenShared'
raster/loader/raster2pgsql.c:701: undefined reference to `GDALGetRasterCount'
raster/loader/raster2pgsql.c:718: undefined reference to `GDALGetProjectionRef'
...

Many more. As of r8375

[strk]

Somehow LDFLAGS gets eaten here. Changing name to the variable fixes the issue for me (like: ALL_LDFLAGS)

[strk]

Droppin the PGXS include also fixes this. Do we really need it for raster2pgsql ?

[dustymugs]

PGXS isn't needed for raster2pgsql. Removed as of r8383.

[dustymugs]

Reverted changes made in r8383 in r8384. PGXS is need to properly install the loader as without it, the bindir variable isn't set. Need to dig at what's happening.

[strk]

works here

[strk]

Oops, sorry, I had local modifications to Makefile. It still fails as of r8383

[dustymugs]

Can you attach the output of the make? I can't seem to understand what could be going wrong.

[strk]

The output clearly shows LDFLAG evaluating to the empty string. I don't think you're doing anything bad, it's more likely PGXS is. Just replacing LDFLAGS with ALL_LDFLAGS (both in definition and use) fixes it for me. I could commit that change but maybe you want to figure out why PGXS is doing that (with postgresql 8.4). Let me know.

[dustymugs]

OK. I'll do some testing with 8.4 as it works fine in 9.0. Will need to test 9.1 as well.

[dustymugs]

Fixed in r8388.

[strk]

confirmed. thanks.