Opened 13 years ago

Closed 7 years ago

#1125 closed defect (wontfix)

pprint_addy fix display of highways, routes and other pretyabbrev

Reported by: robe Owned by: robe
Priority: medium Milestone: PostGIS 2.2.6
Component: tiger geocoder Version: master
Keywords: Cc:

Description

To solve the highway geocoding problem I cheated a bit by just throwing the highway designations in the streetTypeAbbrev with the argument that highways don't ever have streettypes anyway that I can think of and what tiger calls a pretypeabrv, I essentially consider a streetType that happens to be in front of the streetname instead of the back. I have a flag in streettype lookup that traps the nature of this for geocoding called isHighway.

For outputting, I also now cheat by just gluing this in front of the streetname so the pprint_addy behaves right.

I'm swaying back and forth between the decision of adding a true pretypeabrv field to norm_addy and changing pprint_addy to be aware of this field (and basically redoing a good chunk of my work),

OR (which is sounding pretty appealing to me because I am incredibly lazy)

Just have pprint_addy check if the streetypeabrev is a highway type and then just stuff it in front of the address if it is. That solution does make me feel a bit dirty though. So My angel and demons are fighting (angel: "keep clean, everything in its proper place", demon: "be lazy and just stuff the remnants under the covers so no one is the wiser. Really why do we need yet another field"). I'm afraid my demon side is winning this game.

Change History (6)

comment:1 by robe, 13 years ago

Resolution: fixed
Status: newclosed

Took the lazy way for now — fixed at r7646, also got revised geocode to put the pretypabrv in streettype field for now since pprint_addy now correctly picks it up.

Added some of Brian's cass examples from #1077. Brian — if you are listening — I wasn't absolutely sure the output CASS was expecting for these but assumed these are right.

comment:2 by robe, 9 years ago

Resolution: fixed
Status: closedreopened

seems I broke this somewhere down the line. Will remark out the tests until I've fixed.

comment:3 by robe, 9 years ago

Milestone: PostGIS 2.0.0PostGIS 2.2.0
Version: 1.5.Xtrunk

comment:4 by robe, 9 years ago

Milestone: PostGIS 2.2.0PostGIS 2.1.9

comment:5 by pramsey, 7 years ago

Milestone: PostGIS 2.1.9PostGIS 2.2.6

comment:6 by robe, 7 years ago

Resolution: wontfix
Status: reopenedclosed
Note: See TracTickets for help on using tickets.