Opened 13 years ago
Closed 13 years ago
#1117 closed defect (fixed)
ST_OffsetCurve function definition inconsistent with documentation
| Reported by: | robe | Owned by: | strk |
|---|---|---|---|
| Priority: | blocker | Milestone: | PostGIS 2.0.0 |
| Component: | postgis | Version: | master |
| Keywords: | Cc: |
Description
According to the documentation, ST_OffsetCurve is supposed to take text.
When I went to go install the documentation in my database, I get this error:
psql:share/contrib/postgis-2.0/postgis_comments.sql:564: ERROR: function st_offsetcurve( geometry, double precision, text ) does not exist
And I thought hmm — I know I've got this function. So I looked at it, and its defined with cstring?
Why are we using cstring BTW. Never understood what it's for.
Anyrate. Which is right strk — the documentation or the code?
Change History (3)
comment:1 by , 13 years ago
comment:2 by , 13 years ago
| Owner: | changed from to |
|---|---|
| Status: | new → assigned |
comment:3 by , 13 years ago
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
r7629 changes function signature to accept text. The same should be done for ST_Buffer (how come your garden test didn't catch that ?)
Note:
See TracTickets
for help on using tickets.
Oops, I copied from _ST_Buffer, which is taking a cstring. I do see that taking a cstring seems to be a problem (see also the ST_Buffer wrappers) so maybe we should convert both _ST_Buffer and ST_OffsetCurve to take text instead.
The cstring type seems to be only used (beside these two) for canonical text input/output of types.