[raster] ST_ValueCount proto returns integer instead of bigint

[robe]

st_valuecount(rast raster, nband integer, exclude_nodata_value boolean, searchvalue double precision, roundto double precision DEFAULT 0)

others returns big int

also all the record based protos seem to return integer instead of bigint

[dustymugs]

The base ST_ValueCount returns an integer (or a set of) while the coverage ST_ValueCount returns bigint. The coverage version returns bigint because it uses a sum aggregate where PostgreSQL likes to use a bigint for a set of integers. If I had made the base ST_ValueCount return a bigint instead of an integer, the coverage ST_ValueCount would have returned numeric.

[robe]

okay so I guess just fix that one then.

[dustymugs]

I just took a look at all the ST_ValueCount functions and they are all correctly defined. I also took a look at the draft docs and it looks like the base ST_ValueCount functions with the "searchvalue" parameter are incorrectly listed as returning bigint. They all return integer.

bigint ST_ValueCount(raster rast, double precision searchvalue, double precision roundto=0);

bigint ST_ValueCount(raster rast, integer nband, boolean exclude_nodata_value, double precision searchvalue, double precision roundto=0);

bigint ST_ValueCount(raster rast, integer nband, double precision searchvalue, double precision roundto=0);

All three of the protos above return integer instead of bigint. The following example query is of the second proto above and returns an integer.

SELECT * FROM ST_ValueCount(
	ST_SetValue(
		ST_SetValue(
			ST_SetValue(
				ST_AddBand(
					ST_MakeEmptyRaster(10, 10, 10, 10, 2, 2, 0, 0,-1)
					, 1, '64BF', 0, 0
				)
				, 1, 1, 1, -10
			)
			, 1, 5, 4, 0
		)
		, 1, 5, 5, 3.14159
	)
, 1, TRUE, -10, 0);