Make loadState and saveState symmetric

[jmalik]

We need this patch in OTB to avoid a segfault : ​http://hg.orfeo-toolbox.org/OTB/rev/ccacc977358a The patch makes it symetric between the loading and saving of the kwl.

Issue has been discussed here : ​http://bugs.orfeo-toolbox.org/view.php?id=422

[gpotts]

I have added an empty check before accessing the variable in the save state. I need further verification from jmalik before closing the ticket.

[jmalik]

gpotts, your changeset : ​http://trac.osgeo.org/ossim/changeset?new=20596%40trunk%2Fossim%2Fsrc%2Fossim%2Fsupport_data%2FossimQuickbirdMetaData.cpp&old=19900%40trunk%2Fossim%2Fsrc%2Fossim%2Fsupport_data%2FossimQuickbirdMetaData.cpp

corresponds to our first fix : ​http://hg.orfeo-toolbox.org/OTB/rev/5b47d09b000a

So I confirm it is fixed for me and does the job.

However, it seemed more logical to us to use the dual condition wrt what is tested in loadState : ​http://trac.osgeo.org/ossim/browser/trunk/ossim/src/ossim/support_data/ossimQuickbirdMetaData.cpp?rev=20596#L315

Your call !

[gpotts]

You need the else if for it will run without it so the test with Multi will put one form of keywords and the ! empty will always run which you only want to run if Multi is not set. I think that is the flow. Thank you for verification