change app launch bat files to call o4w_env.bat

[maphew]

Go through all the packages and change

PATH=%OSGEO4W_ROOT%\bin;%PATH%
for %%f in ("%OSGEO4W_ROOT%"\etc\ini\*.bat) do call "%%f"

to

call "%OSGEO4W_ROOT%\bin\o4w_env.bat"
start "Foo title" /B "%OSGEO4W_ROOT%\bin\foo.exe" %*

[maphew]

c.f http://trac.osgeo.org/osgeo4w/wiki/PackagingInstructions#Applicationbatchfiletemplate

[jef]

start /b "%OSGEO4W_ROOT%\bin\foo.exe" didn't work for me.

Looks like cmd misinterprets the quoted argument as window title. In the QGIS package I therefore use:

@echo off

SET OSGEO4W_ROOT=@osgeo4w@
call "%OSGEO4W_ROOT%"\bin\o4w_env.bat
@echo off
call "%OSGEO4W_ROOT%"\bin\gdal16.bat

start "Quantum GIS" /B "%OSGEO4W_ROOT%"\bin\qgis.exe %*

The GRASS package now also uses o4w_env.bat

[maphew]

Thank you for catching that jef, I've corrected that instructions accordingly.

[maphew]

Closing ticket. This is best handled by updating the Packaging Instructions # batch file template with the recommended approach (done) and letting the maintainers adjust as suits them.

Also a tweak to the original suggestion to avoid hard coding osgeo4w_root: If bin\foo.bat use:

@echo off
call "%~dp0\o4w_env.bat"
start "Foo window title" /B "%OSGEO4W_ROOT%\bin\foo.exe" %*
@echo on

If apps\foo\foo.bat use:

@echo off
call "~dp0\..\..\bin\o4w_env.bat
start "Foo window title" /B "%OSGEO4W_ROOT%\apps\foo\foo.exe" %*
@echo on