Opened 20 years ago

Closed 20 years ago

Last modified 20 years ago

#702 closed defect (fixed)

MapScript docs for mapObj->setRotation()

Reported by: dmorissette Owned by: mapserverbugs
Priority: high Milestone:
Component: MapScript-PHP Version: 4.3
Severity: normal Keywords:
Cc: sgillies@…

Description

I have written the following description in mapscript/php3/README for the PHP
mapObj method setRotation().

   boolean setRotation(double rotation_angle)
        Set map rotation angle. The map view rectangle (specified in 
        EXTENTS) will be rotated by the indicated angle in the counter-
        clockwise direction. Note that this implies the rendered map 
        will be rotated by the angle in the clockwise direction.
        Returns MS_TRUE/MS_FALSE (true on success, false on error?).

Frank: can you please confirm what the return value means?

Also the doc for the function should be added to the SWIG mapscript.txt

Change History (5)

comment:1 by fwarmerdam, 20 years ago

Resolution: fixed
Status: newclosed
I have fixed msMapComputeGeotransform() to return MS_FAILURE or MS_SUCCESS
and thus also msMapSetRotation(). 

Also, added setRotation() methods docs to mapscript.txt.


comment:2 by dmorissette, 20 years ago

Thanks. I have updated the PHP MapScript README file, and noticed a little typo
in the mapscript.txt:

setRotation(double rotation_angle) : rotation

I believe the return type should be 'int' and not 'rotation', right?  I have
committed that change to CVS as well.

comment:3 by fwarmerdam, 20 years ago

yes, of course you are right.

comment:4 by sgillies@…, 20 years ago

Also, since our high level languages don't have a double type (because our
floats are doubles) let's do

setRotation(float rotation_angle) : int

at least in mapscript.txt.

comment:5 by dmorissette, 20 years ago

I changed double to float in mapscript.txt for setRotation()... and also for
queryByPoint()
Note: See TracTickets for help on using tickets.