Opened 21 years ago

Closed 15 years ago

#42 closed defect (fixed)

Memory leaks

Reported by: dmorissette Owned by: dmorissette
Priority: highest Milestone:
Component: MapServer C Library Version: 4.0
Severity: normal Keywords:
Cc:

Description (last modified by hobu)

From: Assefa Yewondwossen <assefa@dmsolutions.ca>
  To: Daniel Morissette <morissette@dmsolutions.ca>

J'ai roule mapserver 3.5 (avec la getgeatureinfo) et voici les memory
leaks reportes :

1)

  msInsertHashTable+0x8d [maphash.c:42 ip=0x0044432c] (maphash.c, ligne
42)

 struct hashObj *msInsertHashTable(hashTableObj table, char *string,
char *data)
{
  struct hashObj *tp;
  unsigned hashval;

  if(!table || !string || !data)
    return(NULL);

  for(tp=table[hash(string)]; tp!=NULL; tp=tp->next)
    if(strcasecmp(string, tp->key) == 0)
      break;

  if(tp == NULL) { /* not found */
    tp = (struct hashObj *) malloc(sizeof(*tp)); <========= ligne a
problem
  ...

2) lea autres erreurs sont des memory leaks ou on a oublie de freer de
la memoire en sortant de la fonction.

    -  msSHPOpen+0xc1       [mapshape.c:184 ip=0x004508a1]
    -     msSHPDiskTreeOpen+0xf8 [maptree.c:102 ip=0x0045960f]
    -     msSHPDiskTreeOpen+0x4d [maptree.c:88 ip=0x00459564]
    -      msSHPDiskTreeOpen+0x32 [maptree.c:82 ip=0x00459549]
    -     main+0x91            [mapserv.c:1403 ip=0x0040c04e]
    -     initWeb+0xd5         [mapfile.c:2633 ip=0x00416890]
    -     initWeb+0xc2         [mapfile.c:2632 ip=0x0041687d]

Change History (5)

comment:1 by dmorissette, 21 years ago

Cc: steve.lime@… added
Owner: changed from sdlime to assefa

comment:2 by sshealy@…, 21 years ago

I submitted a fix today to steve that fixes this.... He said he submitted it to
the nightly build....

comment:3 by dmorissette, 19 years ago

Owner: changed from assefa to morissette@…
Priority: highhighest
Version: 3.54.0
The above leaks may be fixed already, but I would still like to do a few runs 
using Valgrind (on Linux) to test for leaks.  So I'll keep this open and 
reassing to myself.

comment:4 by hobu, 15 years ago

Description: modified (diff)

Is this bug being held open for its sentimental bug #? ;)

comment:5 by dmorissette, 15 years ago

Resolution: fixed
Status: newclosed

I think it's safe to close this one. We've been doing lots of leak checks and fixes since this bug was opened so these leaks must be long gone.

Note: See TracTickets for help on using tickets.