mapObj->processtemplate() is broken

[stevem@…]

Starting with version 4.0, the mapObj->processtemplate() method no longer 
works. On Windows 2000 (running Apache 2.0.45 and PHP 4.3.2), a very 
simple .map file and .html template work fine when run through the MapServer 
CGI. However, the following PHP script, which should return exactly the same 
web page as the CGI invokation, does nothing:

<?php
  $mapfile = "C:\Programs\ApacheGroup\Apache2\htdocs\simple\simple.map";
  $mo = ms_newMapObj($mapfile);
//  echo $mo->getProjection();
  $tmparray["mode"] = "browse";
  echo $mo->processtemplate($tmparray, MS_TRUE);
?>

I can verify that there is no typo in the map filename, since when I uncomment 
the call to getProjection(), I get a string representation of my map's 
projection, as expected.

Under Linux (Slackware 9.0, PHP 4.3.1, Apache 1.3.x), the behaviour is similar. 
The above script crashes PHP (Segmentation fault), whether it is run through 
the web server, or run at the command-line (using the CLI php executable).

[dmorissette]

Um... after a quick browse of the code I think I see the problem... and after
checking the CVS logs it appears that *I* introduced that problem in MapServer
4.0 (maptemplate.c r1.54) while fixing memory leaks found in bug 171... what a
shame!

Looking into this now.

[dmorissette]

Fixed in V4.3 (CVS) and in 4.2 branch (will be in 4.2.1).

The problem was a broken test on the return value of msReturnPage() in
msProcessTemplate() in maptemplate.c