Opened 11 years ago

Last modified 11 years ago

#3753 assigned task

Exit status should be different from 0 when an error was encountered

Reported by: hopfgartner Owned by: sdlime
Priority: normal Milestone:
Component: Command Line Utilties Version: unspecified
Severity: normal Keywords:
Cc:

Description

Looking through the source of shp2img, it seems that exit status 0 is used even when an error was encountered. The same holds true for mapserv and probably others.

Attachments (7)

sortshp.c.diff (1.5 KB ) - added by hopfgartner 11 years ago.
mapserv.c.diff (1.5 KB ) - added by hopfgartner 11 years ago.
scalebar.c.diff (858 bytes ) - added by hopfgartner 11 years ago.
shp2img.c.diff (1.1 KB ) - added by hopfgartner 11 years ago.
sym2img.c.diff (382 bytes ) - added by hopfgartner 11 years ago.
mapserv.c.2.diff (1.2 KB ) - added by hopfgartner 11 years ago.
shptree.c.2.diff (632 bytes ) - added by hopfgartner 11 years ago.

Download all attachments as: .zip

Change History (10)

by hopfgartner, 11 years ago

Attachment: sortshp.c.diff added

by hopfgartner, 11 years ago

Attachment: mapserv.c.diff added

by hopfgartner, 11 years ago

Attachment: scalebar.c.diff added

by hopfgartner, 11 years ago

Attachment: shp2img.c.diff added

by hopfgartner, 11 years ago

Attachment: sym2img.c.diff added

comment:1 by sdlime, 11 years ago

Status: newassigned

Will get these into beta 4, the changes look otherwise benign... Steve

comment:2 by sdlime, 11 years ago

Most of this is done for beta4 (see r11397). I found some of the diffs missed a case or two. The mapserv.c.diff is not for mapserv.c so that source has not been touched yet. There's another beta next week we can hit with that if you post a patch.

Steve

comment:3 by hopfgartner, 11 years ago

Second round: on mapserv.c I'm not that sure on some of the exits.

by hopfgartner, 11 years ago

Attachment: mapserv.c.2.diff added

by hopfgartner, 11 years ago

Attachment: shptree.c.2.diff added
Note: See TracTickets for help on using tickets.