Opened 14 years ago

Closed 13 years ago

#3172 closed enhancement (fixed)

Expose templated format list to WFS GetFeature and WMS GetFeatureInfo

Reported by: dmorissette Owned by: assefa
Priority: normal Milestone: 6.0 release
Component: Documentation - MapServer Version: unspecified
Severity: normal Keywords:
Cc: aboudreault, assefa, sdlime, dmorissette, tomkralidis, warmerdam

Description (last modified by dmorissette)

The templated output formats (added in RFC 36, ticket #2576) should be exposed to WFS GetFeature and WMS GetFeatureInfo through the use of metadata entries similar to what was done for WMS GetMap (wms_getmap_formatlist) in ticket #455. i.e.

  • Add a "wfs_getfeature_formatlist" which is a comma-delimited list of outputformat names or mime-types to offer for WFS GetFeature
  • Add a "wms_getfeatureinfo_formatlist" which is a comma-delimited list of outputformat names or mime-types to offer for WMS GetFeatureInfo
  • The current "wms_feature_info_mime_type" metadata should be marked as deprecated and the use of "wms_getfeatureinfo_formatlist" encouraged instead

While we're at it, the lookup and parsing of this metadata should be moved to a reusable utility function instead of duplicating the code that is currently found in two places in mapwms.c.

Finally, relevant documentation needs to be updated.

Change History (9)

comment:1 by dmorissette, 14 years ago

Description: modified (diff)

comment:2 by dmorissette, 14 years ago

Milestone: 5.6 release6.0 release

Steve, I find that it's kind of late to get this in beta4 if we want to release someday. Pushing to 6.0 for now as this is not a critical fix but more the completion of a new feature.

comment:3 by dmorissette, 14 years ago

Well, if you feel strongly about getting this in 5.6 then I'm not completely adverse, but someone would need to grab and complete this before beta4.

comment:4 by sdlime, 14 years ago

Change to 6.0 is ok with me. -Steve

comment:5 by assefa, 14 years ago

Cc: dmorissette added
Owner: changed from dmorissette to assefa

looking into this bug ...

comment:6 by assefa, 14 years ago

Cc: tomkralidis added
Type: defectenhancement

some questions on the getfeatureinfo_formatlist:

  • if a user defines a getfeatureinfo_formatlist, do we always include text/plain and GML as supported formats or only expose those listed in the metadata?
  • right now, the default output for the GetFeatureInfo is text/plain if the request does not have the optional INFO_FORMAT parameter. Do we need to keep that if there is a predefined list of format list defined or should we default to the first format in the list. This is tricky, since it would break existing apps expecting always text/plain.

My take would be to always include text/plain and GML + the list of formats defined. Less risque of breaking existing setups.

comment:7 by assefa, 14 years ago

Added the support for WMS getFeatureInfo. I kept what was there originally where text/plain and GML are always exposed) r9635

Missing WFS and docs

comment:8 by warmerdam, 13 years ago

Cc: warmerdam added

I'm looking at implementing the new template support for WFS GetFeature, as well as my work on integrating OGR output from WFS GetFeature.

comment:9 by assefa, 13 years ago

Component: WFS ServerMapServer Documentation
Resolution: fixed
Status: newclosed

closing. this was implemented. Docs added in r11580 r11581

Note: See TracTickets for help on using tickets.