Opened 15 years ago
Closed 15 years ago
#2948 closed defect (fixed)
RFC 55 implementation: Improve control of output resolution
Reported by: | aboudreault | Owned by: | aboudreault |
---|---|---|---|
Priority: | normal | Milestone: | 5.6 release |
Component: | MapServer C Library | Version: | svn-trunk (development) |
Severity: | normal | Keywords: | output, resolution |
Cc: | dmorissette, tbonfort, assefa, cnieman |
Description
Ticket to track changes with regards to RFC 55, output resolution:
Attachments (1)
Change History (11)
comment:1 by , 15 years ago
Cc: | added |
---|
comment:2 by , 15 years ago
comment:3 by , 15 years ago
Cc: | added |
---|
Committed in SVN trunk in r8843.
Assefa, may you run your series of tests with the trunk pls? Thanks
comment:4 by , 15 years ago
I'm not sure if Assefa has taken a look at the code you committed yet, but we just realized that the maximum width of symbols is set to 32 unless otherwise specified. So MAXSCALE for each style needs to be scaled (or changed in some other way).
comment:6 by , 15 years ago
Cc: | added |
---|
So, that those 4 values should be scaled too: style->maxwidth, style->minwidth, style->minsize, style->maxsize. cnieman, perhaps you have a small test case to attach in the ticket ? It would allow me to quickly test my changes.
Assefa, I think you have a few applications that use different output resolution ? Am I right? Maybe it would be a good idea to test them with a MS 5.6 beta before the official release ?
comment:7 by , 15 years ago
Milestone: | 6.0 release → 5.6 release |
---|
Since this has been committed in the code a while ago, and was part of the first few 5.6 betas, would it not be better close this ticket and open new ones if there are issues?
comment:8 by , 15 years ago
Alan,
we still use 5.4 for production. That's why I did not do a full test on this feature yet. Hopefully Christy has a test case showing the need to scale MAX/MIN-WIDTH/SIZE.
Daniel,
Opening new tickets is ok with me. If the fixes are easy I would suggest keeping them here for easy reference.
comment:9 by , 15 years ago
I've attached an example with three line styles. When we scaled these styles for print [(width/resolution)*dpi] which was, for example, in the first class of the attached sample, [(16/96)*300 = 50] and [(10/96)*300 = 31.25] we found that the ratio between the two line widths was not consistent with what was displayed with no scaling; the line that should have had a width of 50 was only getting drawn with a width of 32 because of the default MAXWIDTH value. When MAXWIDTH was set using the same scaling calculation, the lines were drawn with the correct ratio between the widths.
comment:10 by , 15 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
This implementation is done. Let's track issues in new tickets.
Style MAXWIDTH issue: http://trac.osgeo.org/mapserver/ticket/3153
A good part of this task have been done. Here's some notes i've took during the implementation:
IMP: Most of outlines cannot be scaled with the current version of GD.
IMP: not fully supported no backgroundcolor / backgroundshadow ...
IMP: not fully supported no backgroundcolor backgroundshadow
IMP: not fully supported no backgroundcolor / backgroundshadow...