Tag parsing in template code fails if ]'s are in arguments, even if quoted.

[sdlime]

A tag like this is useful for outputting GeoJSON:

  [shpxy precision="0" ph="[" pf="]" xh="[" yf="]" ps=","]

It constructs a part from an array of points. MapServer 5.2 segfaults with this. Turning the inside ]'s into something else makes things work but is useless. The tag parser needs to be smarter and skip these characters IF then are in quotes.

Steve

[aboudreault]

Steve, do you have an example of mapfile/data that i can use to test this bug ?

[aboudreault]

It's ok Steve, i've found a demo here that i can use.

[sdlime]

Crap, sorry. I meant to do that this morning and got distracted.

Steve

[aboudreault]

No problem Steve. Here's a patch for allowing ']' character in template (have to be quoted).

Note: Before, the character ']' was used in internal processing to allow the parser to output '=' character in the template. So, in the first part of the process, '=' was converted in ']' and in the second part all character ']' was converted in a '='. I replaced this replacement by a '\' character. This result to if we put a '\' in the template, it will be transformed in a '='. Do you think that can cause a problem ? If so, we can just take another one character.k

[dmorissette]

My first reaction is that yes, having all '\' converted to '=' will be a bad side-effect. (I'd have to look at the code but I don't understand why '=' had to be converted to ']' in the previous version)

[aboudreault]

I think it's becauce of the msStringSplit method that is used to split arguments (name=value). If i remember well, it fails if the value contains a '='.

[aboudreault]

I joined a new patch. We improved the tags parsing method. We can now put any character inside the quotes of the tags values. For the character ", write two consecutive ".

[sdlime]

Great news! This will really help with some of the more complex tag processing done in the newer template support. Has this been committed to the trunk?

Steve

[dmorissette]

No, he has not committed to trunk yet. He has attached a patch for review, once we confirm that it looks good he will commit. If you want to test it and report then that would be great.

[sdlime]

I have some good tests to try and will do so this week. I'll do some JSON output and tags within tags using [item ...].

Steve

[aboudreault]

Steve, did you have the time to do the JSON tests ? It's ok if you didn't, it's not urgent. I just wondering if...

[dmorissette]

Alan, I'd say go ahead and commit trunk and close this ticket. If there are problems they can be filed as new tickets and fixed later.

[aboudreault]

Commited to SVN trunk in r8268.

[aboudreault]

Documentation has been updated in r8269.