Opened 16 years ago
Closed 13 years ago
#2753 closed enhancement (fixed)
[GEOS] Add simplify function to php/mapscript
Reported by: | jlacroix | Owned by: | jmckenna |
---|---|---|---|
Priority: | normal | Milestone: | 5.6 release |
Component: | Documentation - MapServer | Version: | unspecified |
Severity: | normal | Keywords: | |
Cc: | sdlime, assefa, dmorissette, aboudreault, havatv |
Description
There's a simplify function in GEOS and it would be cool to have access to it through mapscript. See the following exchange to see the interest around it.
http://www.nabble.com/vertex-simplification-td13442613.html
Attachments (1)
Change History (12)
by , 16 years ago
Attachment: | simplify.patch added |
---|
comment:1 by , 16 years ago
Cc: | added |
---|---|
Milestone: | → 5.4 release |
Owner: | changed from | to
Status: | new → assigned |
To summarize, the patch adds the following functions in mapgeos.c:
shapeObj *msGEOSSimplify(shapeObj *shape, double tolerance); shapeObj *msGEOSTopologyPreservingSimplify(shapeObj *shape, double tolerance);
... and the following methods in MapScript:
shapeObj shapeObj.simplify(double tolerance) shapeObj shapeObj.topologyPreservingSimplify(double tolerance)
Steve, if you agree with this addition then we'll commit the patch for PHP MapScript and you can then add the methods to SWIG MapScript.
comment:2 by , 16 years ago
Sounds ok to me. Just assign to me once you complete the PHP part and then I'll do SWIG and then assign to the documentation component.
Steve
comment:3 by , 16 years ago
Owner: | changed from | to
---|---|
Status: | assigned → new |
Cool. I'll let Julien take care of it and he will reassign to you after.
comment:4 by , 14 years ago
Cc: | added |
---|
Do you guys want to get this into 5.6 yet? Only addition would be adding methods on the Swig side. I'd do that if you want to move forward.
Steve
comment:5 by , 14 years ago
Cc: | added |
---|---|
Owner: | changed from | to
Too late for 5.6, but let's take care of this early in 6.0
comment:6 by , 14 years ago
Milestone: | 5.6 release → 6.0 release |
---|
comment:7 by , 14 years ago
Component: | MapScript-PHP → MapServer Documentation |
---|---|
Milestone: | 6.0 release → 5.6 release |
Patch won't apply clean against trunk, but it was just the ZEND_DEBUG hunk which looks not to be a problem. I also added methods to shape.i in the Swig stuff. I tested the compile there but not for PHP. Could someone verify the PHP build please?
Moving to documentation component...
Steve
comment:8 by , 14 years ago
Owner: | changed from | to
---|
Assigned to Jeff for docs. The new methods to document are:
shapeObj shapeObj.simplify(double tolerance) shapeObj shapeObj.topologyPreservingSimplify(double tolerance)
comment:10 by , 14 years ago
I found out at the last minute while packaging 5.6.0-rc1 that this addition broke the buildbots which are using GEOS 2.2.3. It seems that GEOSSimplify and GEOSTopologyPreserveSimplify are only in GEOS 3.0+.
I committed a patch in r9569 that enables the new methods only for GEOS 3.0+. This is included in 5.6.0-rc1.
I also created ticket #3215 about possibly bumping up the GEOS requirement to 3.0+ in Mapserver 6.0.
comment:11 by , 13 years ago
Cc: | added |
---|---|
Resolution: | → fixed |
Status: | new → closed |
patch to include the simplify functions in php/mapscript