Memory leak in msOracleSpatialLayerGetShape()

[jimk]

I found a memory leak in maporaclespatial.c in msOracleSpatialLayerGetShape that was preventing me from retrieving large datasets via WFS from an Oracle Spatial source.

layerinfo->items_query = (item_text_array_query *)malloc( sizeof(item_text_array_query) * (layer->numitems) );

(Line 2052 in v5.0.2)

This is allocated every time the function is called and is never freed.

I put this:

if(layerinfo->items_query) free(layerinfo->items_query); JSK 2008-04-16 try to clean up memory leak in big datasets

one line previous to it to fix it, but looking at the code it may be sufficient to just check if items_query is null and only execute the malloc if items_query is null.

[jimk]

Also see #2927

[dmorissette]

Fixed in SVN trunk (6.0) r8715.