WMS GetLegendGraphic doesn't listen to TRANSPARENT in OUTPUTFORMAT

[bartvde]

Whereas mode=legend does listen to this to determine whether or not the legend should be transparent.

[bartvde]

patch fixing the issue

[tomkralidis]

new patch against latest svn trunk

[tomkralidis]

Bart: I've added a new patch based on the latest svn trunk (I made a bunch of changes for #2384 last night).

Note that we should probably add msautotest/wxs test cases for this (we have none for GetLegendGraphic). Norm: if you can provide some info on how to add binary outputs for msautotest/wxs, then I can add.

[bartvde]

Hi Tom, is this something you only want to fix in trunk or also in 5.0.3?

[tomkralidis]

Right. Both. I'll wait for someone on mapserverbugs to commit this to both, then I'll work on the msautotest/wxs cases.

[nsavard]

Replying to tomkralidis:

Bart: I've added a new patch based on the latest svn trunk (I made a bunch of changes for #2384 last night).

Note that we should probably add msautotest/wxs test cases for this (we have none for GetLegendGraphic). Norm: if you can provide some info on how to add binary outputs for msautotest/wxs, then I can add.

Tom:

If you are talking about how to output image than here is an example (tomkworkshop.map). You only have to add RESULT_DEMIME.

# Generate WMS GetLegendGraphic # RUN_PARMS: wms_get_legend_graphic.png [MAPSERV] QUERY_STRING="map=[MAPFILE]&version=1.1.1&service=WMS& request=GetLegendGraphic&layer=rivers&format=image/png" > [RESULT_DEMIME]

[dmorissette]

Tom, I reviewed the patch and it seems safe. I'd say go ahead and commit to both trunk and branch-5-0.

[tomkralidis]

Done:

• change made in trunk in r7369
• change made in branch-5-0 in r7370
• since msautotest/wxs already had a GetLegendGraphic test, I did not add one