Opened 16 years ago

Closed 16 years ago

#2430 closed defect (fixed)

[PATCH] postgis driver segfaults on invalid input

Reported by: brentp Owned by: mapserver-bugs@…
Priority: normal Milestone: 5.0.1 release
Component: PostGIS Interface Version: unspecified
Severity: major Keywords: postgis
Cc:

Description

t.map 

MAP
  NAME "Testing"
  EXTENT -0.5 50.977222 0.5 51.977222
 
  LAYER
    NAME "POLYGON"
    CONNECTIONTYPE POSTGIS
    TYPE POLYGON
    PROJECTION
      "init=epsg:4326"
    END
    STATUS DEFAULT
    DATA "polygon"
  END
END

to create segfault:

shp2img -m t.map -l "POLYGON" -s 500 500

Attachments (1)

mapserver_svn_trunk_fix_postgis_segfault_bug2430.patch​ (660 bytes ) - added by rouault 16 years ago.

Download all attachments as: .zip

Change History (4)

comment:1 by rouault, 16 years ago

Milestone: → 5.0.1 release
Summary: postgis driver segfaults on invalid input → [PATCH] postgis driver segfaults on invalid input

Attached patch that checks that layer->connection != NULL

by rouault, 16 years ago

Attachment: mapserver_svn_trunk_fix_postgis_segfault_bug2430.patch​ added

comment:2 by tomkralidis, 16 years ago

FYI, just tested this. I can reproduce this behaviour and that the patch works as expected when applied: 

$ shp2img -m ./config.map -l POLYGON -o foo.png
msDrawMap(): Image handling error. Failed to draw layer named 'POLYGON'. <br>
msPOSTGISLayerOpen(): General error message. Missing CONNECTION keyword <br>

This should be able to make it for next week's 5.0.1 release.

comment:3 by sdlime, 16 years ago

Resolution: → fixed
Status: new → closed

Fixed in 5.0 branch and the main trunk.

Steve

Note: See TracTickets for help on using tickets.