Content-type in Post Requests

[silke.reimer@…]

When the client doesn't send an content-type in the HTTP-header mapserver
segfaults. The patch below fixes the problem.

diff -ur mapserver-4.8.0-rc2/cgiutil.c mapserver-4.8.0-rc2.new/cgiutil.c
--- mapserver-4.8.0-rc2/cgiutil.c       2006-01-26 15:00:33.000000000 +0100
+++ mapserver-4.8.0-rc2.new/cgiutil.c   2006-01-26 15:00:26.000000000 +0100
@@ -129,9 +129,14 @@
     char *post_data;

     request->type = MS_POST_REQUEST;
-    request->contenttype = strdup(getenv("CONTENT_TYPE"));
-
     post_data = readPostBody( request );
+    if (s = getenv("CONTENT_TYPE"))
+       request->contenttype = strdup(s);
+    /* we've to set default content-type which is
+     * application/octet-stream according to
+     * W3 RFC 2626 section 7.2.1 */
+    else request->contenttype = "application/octet-stream";
+
     if(strcmp(request->contenttype, "application/x-www-form-urlencoded"))
         request->postrequest = post_data;
     else

[sdlime]

For whatever reason the patch below bombs on my machine. I think there's a small
problem. Shouldn't:

  request->contenttype = "application/octet-stream";

be:

  request->contenttype = strdup("application/octet-stream");

to avoid problems when free'ing request->contenttype later?

Steve

[silke.reimer@…]

Yes, I think you are right. Could you please change the patch accordingly?

Does this solve your problem with this patch?

Silke

[sdlime]

I tweaked the patch and applied to CVS HEAD and 4.8. Thanks for your help on
this one Silke. Marking as fixed.

Steve