Opened 19 years ago

Closed 17 years ago

#1437 closed defect (fixed)

Change main header file name (or provide alternative)

Reported by: andrew.bell.ia@… Owned by: dmorissette
Priority: high Milestone: 5.0 release
Component: Build Problems Version: unspecified
Severity: normal Keywords:
Cc: sgillies@…

Description (last modified by dmorissette)

map.h was used to store C++ library map data structure definitions before the standard became formal and still exists on many systems. This can cause a conflict which searching for the mapserver map.h file. Suggest renaming map.h, or providing an alternative file (mapserver.h, perhaps) which would simply include a well-specified map.h to avoid naming conflicts:


#include "./map.h"


Change History (6)

comment:1 by dmorissette, 19 years ago

Cc: hobu@… warmerdam@… sgillies@… steve.lime@… mapserver-bugs@… added
Owner: changed from mapserverbugs to dmorissette@…
I have always feared that the name map.h was a bit too generic and could
eventually cause conflicts.

I think renaming it to something like mapserver.h might be best, unless we're
worried that this could possibly cause confusions with the already existing

Adding other developers to CC to get their thoughts.

comment:2 by sdlime, 19 years ago

mapserver.h sounds fine to me. I can't see why changing that would impact users 
at all. - Steve

comment:3 by fwarmerdam, 19 years ago

I am ok with changing it to mapserver.h, but I can't help but wonder if there
is any other rationalization we ought to do at the same time.  

comment:4 by hobu, 17 years ago

Description: modified (diff)
Milestone: 5.0 release

Should we revisit this change for the 5.0 release? Any external clients using MapServer through C would be affected, but all of the mapscripts could be changed without much trouble.

comment:5 by dmorissette, 17 years ago

Description: modified (diff)

comment:6 by dmorissette, 17 years ago

Resolution: fixed
Status: newclosed

It has been decided by vote of the PSC on the -dev list to rename map.h -> mapserver.h.

This change has been committed to SVN in r6373 (v4.99). Closing ticket.

Note: See TracTickets for help on using tickets.