Changes between Version 3 and Version 4 of SubmitPatch


Ignore:
Timestamp:
Mar 4, 2009, 9:00:56 AM (15 years ago)
Author:
tomfukushima
Comment:

--

Legend:

Unmodified
Added
Removed
Modified

  • SubmitPatch

    v3 v4  
    77Prerequisite: you need to be subscribed to the [http://lists.osgeo.org/mailman/listinfo/mapguide-internals mapguide-internals mailing list].
    88
    9 Mail patches to mapguide-internals@lists.osgeo.org, with a subject line that starts with "PATCH:" in all uppercase, for example
     9Attach patch to the trac ticket that it applies to. Mail the mapguide-internals mailing list and state that there is a patch available for review.  Start the subject line with PATCH: Ticket nnn <ticket description>.  In the message body include any details that will be useful to anyone reviewing the change.
    1010
    11 Subject: PATCH: fix for legend resizing problem in web layout
     11The patch itself should be in unified diff format (e.g., "svn diff", "diff -u" or if you are using Tortoise SVN use the "Create Patch..." command). Send the patch as an attachment, with a mime-type of text/x-diff, text/x-patch, or text/plain.
     12
    1213
    1314A patch submission should contain one logical change; please don't mix N unrelated changes in one submission — send N separate emails instead.
    1415
    15 The patch itself should be in unified diff format (e.g., "svn diff", "diff -u" or if you are using Tortoise SVN use the "Create Patch..." command). Send the patch as an attachment, with a mime-type of text/x-diff, text/x-patch, or text/plain.
     16Once the patch has been submitted, expect some feedback from reviewers of the patch. It may take several rounds of feedback before the patch is applied by a committer. If you don't get a response and don't see the patch applied, it's fine to repost and point out that you're still waiting for a response. The best person to make sure that the patch gets applied is you.
    1617
    17 In the email message body: if the patch implements a new feature, make sure to reference the RFC (see [http://mapguide.osgeo.org/psc.html Project Steering Committee] for a description of RFCs) that describes the change; if the patch fixes a bug, reference the Trac ticket number. Also include any details that will be useful to anyone reviewing the changes.
    18 
    19 Once the patch has been submitted, expect some feedback from reviewers of the patch. It may take several rounds of feedback before the patch is applied by a committer. If you don't get a response and don't see the patch applied, it's fine to repost and point out that you're still waiting for a response. The best person to make sure that the patch gets applied is you.
     18Typically, the discussion of the patch should happen within the ticket and not in mapguide-internals.