One exception happened with load procedure when Library data file folder doesn't exist.

[stevenxu]

Steps

1. Launch Site Administrator->Configure Services->Set Library data file folder as C:/Program Files/Autodesk/MapGuideEnterprise2010/Server/Repositories/Library/DataFiles/Test/NonExistFolder->Save
   
2. Restart the Mapguide service.
   
3. Launch Studio.
   
4. New -> Load Procedure->Select any type file->Click Load Resources

Results: One exception happened.

Expected results: One new folder should be created automatically if setting a non-existed folder in the configure web.

[stevenxu]

According to what Steve Dang said:

By default, the Server will create fresh repositories at startup if they do not exist. Let’s make things simple, i.e. Create the repository/resource data file paths if they do not exist and throw an exception when this fails in:

MgLibraryRepository::VerifyAccess(CREFSTRING repositoryPath) MgSessionRepository::VerifyAccess(CREFSTRING repositoryPath) MgSiteRepository::VerifyAccess(CREFSTRING repositoryPath)

[stevenxu]

Ticket890.patch is my fix.

In my fix I verified the following folers:

Library data file folder: Repositories/Library/DataFiles/ Library repository folder: Repositories/Library/ Session data file folder: Repositories/Session/DataFiles/ Session repository folder: Repositories/Session/ Site repository folder: Repositories/Site/ Tile cache path: Repositories/TileCache/

[stevenxu]

Library data file folder: Repositories/Library/DataFiles/
Library repository folder: Repositories/Library/
Session data file folder: Repositories/Session/DataFiles/
Session repository folder: Repositories/Session/
Site repository folder: Repositories/Site/
Tile cache path: Repositories/TileCache/

[stevedang]

Nice work Steven! Just a few comments:

Common/Foundation/System/FileUtil.h:

• It's nice that you added a new comprehensive/internal method, MakeDirectory.
• Consider renaming it to CreateDirectories for consistency with the other overloaded method.

Common\Foundation\System\FileUtil.cpp:

Lines 439, 449:

• Please use 4-space tab/indentation.

Line 443 - if( path.find_first_of(sm_slash)==0)

• I'm not sure what this check is for.
• To make this method complete, it should also handle UCN pathnames (though not supported for repositories' locations), and of course work on Linux. Otherwise, you will need to document this limitation.
• To optimize this method, we should check if the path already exists before walking through it.

Line 450:

• Not needed.

Line 458-460:

• Please use size_t's instead of int's.

Line 467 - if( PathnameExists(subPath))

• Not needed because for consistency in both CreateDirectory and CreateDirectories methods, the "strict" flag should be only used to determine if the method should throw an exception when the path already exists.

Server/src/Services/Tile/TileCache.cpp:

Line 55 - if (!MgFileUtil::PathnameExists(sm_path))

• Not needed.

[tomfukushima]

Assigning to Steve Dang as he is reviewing and will submit. Thanks Steve.

[tomfukushima]

Arghh. Trying again to assign to Steve.

[stevenxu]

Update of patch

[stevenxu]

The latest patch of Ticket890_V2.patch made the all changes of steve dang's comments, expect that, I changed the function name as 'CreateDirectoryEx' in Common/Foundation/System/FileUtil.h, instead of 'CreateDirectory'.

As following:

static void CreateDirectory(CREFSTRING path, bool strict = false);

static void CreateDirectoryEx(CREFSTRING path, bool recursive = true, bool strict = false);

For the default value of the parameter, the same function names would result in ambiguous overloaded functions.

[stevenxu]

The latest patch Ticket890_V3rd.patch included:

1. Expand the existing function: CreateDirectory(CREFSTRING path, bool strict = false) as CreateDirectory(CREFSTRING path, bool strict = false, bool recursive=false), so that it can create parent directories recursively.

2. Make the new add code in the method CreateDirectory more readable.

[StevenXu]

The latest patch V5th made some changes on the code style in order to follow the coding fuidelines consistently.

[stevenxu]

It was fixed in trunk: ​http://trac.osgeo.org/mapguide/changeset/3749