Polygon features are drawn wrong when not completely in the window (part 2)

[waltweltonlair]

​Ticket 754 described some rendering quirks that occur with the new stylization engine as a result of feature geometry being clipped to the edge of the visible window. This ticket is for the exact same problem, but against old stylization.

[waltweltonlair]

Feature processing now occurs as follows:

• get the unclipped geometry from the feature reader
• call the adapter's Stylize method with the unclipped geometry
• each adapter computes the required clip offset
• each adapter clips the feature geometry, taking into account any offset
• each adapter applies the style to the clipped geometry

The following code changes have been made:

• DefaultStylizer.cpp
  • removed clipping code in StylizeVLHelper
  • pass in the unmodified feature geometry to the Stylize call on the adapter

• PolygonAdapter.h
• PolygonAdapter.cpp
• PolylineAdapter.h
• PolylineAdapter.cpp
• PointAdapter.h
• PointAdapter.cpp
  • added code in Stylize to compute the clip offset from the style
  • added code in Stylize to clip using the offset

• GeometryAdapter.h
• GeometryAdapter.cpp
  • added a GetClipOffset method which computes the necessary offset for a given RS_LineStroke
  • the method takes into account line width and decorations

• SE_SymbolDefProxies.h
• LineBuffer.cpp
• StylizationDefs.h
• StylizationEngine.h
• SE_LineBuffer.cpp
• SE_LineRenderer.h
  • replaced #defines of numbers with 'const' declarations
  • moved most declarations into StylizationDefs.h

• StylizationEngine.cpp
  • minor cleanup

I also fixed a problem in PointAdapter. The StartFeature notification was not being done in the case where a label is used as the symbol.

Finally, I updated the FENCELINE1 rendering code in AGGRenderer and GDRenderer to use up to 64 segments for approximating circular decorations.

[waltweltonlair]

Fixed in trunk with submission ​https://trac.osgeo.org/mapguide/changeset/3451.