Opened 7 years ago

Closed 6 years ago

#2524 closed task (fixed)

Review places where argument / null reference exceptions are thrown

Reported by: jng Owned by: jng
Priority: low Milestone: 3.0
Component: General Version:
Severity: trivial Keywords:
Cc: External ID:

Description (last modified by jng)

There are still some places in the MapGuide codebase where naked MgNullArgumentException and MgNullReferenceException objects are thrown.

Cases where these are thrown provide no useful context for the developer as it lack key important information: The name of the argument that is null.

We already have a CHECKARGUMENTNULL() and CHECKNULL() macros to inject the argument name when throwing the exception. We need to find all cases where such exceptions are still manually thrown and replace them with this macro.

Change History (3)

comment:1 by jng, 7 years ago

Description: modified (diff)
Summary: Review places where argument exceptions are thrownReview places where argument / null reference exceptions are thrown

comment:2 by jng, 7 years ago

Coding standards updated to strongly suggest use of these macros instead of doing manual argument checking.

comment:3 by jng, 6 years ago

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.