Opened 11 years ago
Closed 11 years ago
#2440 closed defect (fixed)
Maestro - Diff Confusion with encoding and whitespace
Reported by: | crispinatime | Owned by: | jng |
---|---|---|---|
Priority: | low | Milestone: | Maestro-6.0 |
Component: | Maestro | Version: | |
Severity: | minor | Keywords: | |
Cc: | External ID: |
Description
The "Diff" capability in Maestro is very powerful - but also slightly confusing on a couple of elements.
1) XML Encoding When opening a resource e.g. .LayerDefinition in XML mode I see the first line as:
<?xml version="1.0"?>
If I then edit the XML and use the Diff function it highlights the first line as red and says that the actual source was
<?xml version="1.0" encoding="UTF-8"?>
Implying the XML editor is stripping the encoding before showing the text XML and firing a dirty state
2) Whitespace If I have a vector .LayerDefinition resource with a filter, and add a space at the end of the filter when opened in XML mode then I would expect that line to be highlighted as different in the Diff viewer. It is not.
Neither element is major here, just some finesse if possible.
Change History (4)
comment:1 by , 11 years ago
comment:3 by , 11 years ago
Resolution: | fixed |
---|---|
Status: | closed → reopened |
Looks great - 100% - for the UI editor.
But not for XML editing.
But if I open any resource in XML mode and make any (including invalid schema) modifications then the "View Changes" diff shows nothing.
comment:4 by , 11 years ago
Resolution: | → fixed |
---|---|
Status: | reopened → closed |
Fixed the generic XML editor portion in r8119
That's strange. I funnel both sides through XmlDocument objects first to normalize them both before doing the actual comparison. Must be some other settings that can be set.