Opened 13 years ago

Closed 13 years ago

#1843 closed defect (fixed)

Only fetch properties if property pane is visible

Reported by: gabrimonfa Owned by:
Priority: low Milestone:
Component: General Version: 2.2.0
Severity: trivial Keywords:
Cc: External ID:

Description

Mapguide 2.2 OS: don't care

I've noticed that properties are fetched even if property pane is not visible (disabling it in webLayout XML).

This is important because under certain conditions property fetch takes a lot of time

I've also seen changeset 4138 and 4139 made by jng but they do not seem to address properly the case where property pane is disabled from webLayout.

We do have a variable (isProperties) that holds whether property pane is enabled or not.

Thus I propose the following enhancement to the IsPropertyCtrlVisible() function

function IsPropertyCtrlVisible()
{
+    if (!isProperties) return false;
    return GetPropertyCtrl().width > 0;
}

Change History (1)

comment:1 by jng, 13 years ago

Resolution: fixed
Status: newclosed

Fixed r6198 (trunk) r6199 (2.2). Thanks for the patch

Note: See TracTickets for help on using tickets.