Possible bug in constructor MgSelection (MgMap *map, CREFSTRING xmlSelectionString) triggered by empty xmlSelectionString

[gabrimonfa]

I have mapguide 2.1.0 on Debian etch with apache (let's call it mapguide_apache) and php. In my setup main apache web server is configured to use mapguide_apache with proxy/reverseProxy directives.

If MgSelection (MgMap *map, CREFSTRING xmlSelectionString) is called with an empty xmlSelectionString (it happens when no elements are selected in the map), my main apache logs:

502 Proxy Error

while mapguide_apache logs

[notice] child pid 24438 exit signal Segmentation fault (11)

The server appears to continue without problems but I'm not sure since I have also sporadic crashes (without log entries...)

[jng]

The MgSelection constructor just delegates to its parent constructor, which internally calls the FromXml() method (​http://trac.osgeo.org/mapguide/browser/trunk/MgDev/Common/PlatformBase/MapLayer/SelectionBase.cpp#L104)

From what I can see, it just assumes as though the selection string is not empty (it doesn't actually check for an empty string).

I guess the solution is to check for an empty string, but then what to do once we encounter an empty string? Do nothing (return)? Throw MG exception?

[gabrimonfa]

Is that solved in 2.2RC1 or in trunk?

[jng]

Fixed trunk (r6758) and 2.4 (r6756)