Opened 15 years ago

Closed 15 years ago

#1082 closed defect (fixed)

Existing basic web layout should not ping server by default

Reported by: christinebao Owned by: Chris Claydon
Priority: medium Milestone: 2.2
Component: AJAX Viewer Version: 2.0.2
Severity: major Keywords:
Cc: External ID: 1249172

Description

From Autodesk QA report:

Steps:

  1. Open a basic web layout created before.
  2. The "Keep connection alive" in Studio is not checked.
  3. Using Firefox to open the basic web layout, and it pings server.

Expected: The basic web layout created before should keep the same behavior as it was.

Attachments (1)

FixTicket#1082.patch (614 bytes ) - added by christinebao 15 years ago.

Download all attachments as: .zip

Change History (5)

comment:1 by christinebao, 15 years ago

Tech diagnosis:

Basic web layout read from bool MgWebLayout::GetEnablePingServer() to know whether or not should ping server. It works for basic web layout created since schema change:
WebLayout-1.1.0.xsd

  <xs:element name="WebLayout" type="WebLayoutType"/>
  <xs:complexType name="WebLayoutType">
    <xs:sequence>
      <xs:element name="Title" type="xs:string"/>
      <xs:element name="Map" type="MapType"/>
      <xs:element name="EnablePingServer" type="xs:boolean" minOccurs="0" />
      <xs:element name="ToolBar" type="ToolBarType"/>
      <xs:element name="InformationPane" type="InformationPaneType"/>
      <xs:element name="ContextMenu" type="ContextMenuType"/>
      <xs:element name="TaskPane" type="TaskPaneType"/>
      <xs:element name="StatusBar" type="StatusBarType"/>
      <xs:element name="ZoomControl" type="ZoomControlType"/>
      <xs:element name="CommandSet" type="CommandSetType"/>
    </xs:sequence>
  </xs:complexType>


The element <EnablePingServer> indicates whether or not the basic web layout should ping server.
However, for the basic web layout created before, there is not such <EnablePingServer> element. The default value should be set as false instead of true, so the existing basic web layout can keep the same behavior as before.

by christinebao, 15 years ago

Attachment: FixTicket#1082.patch added

comment:2 by christinebao, 15 years ago

Hi Chris,

Would you please review patch https://trac.osgeo.org/mapguide/attachment/ticket/1082/FixTicket%231082.patch? It's appreciated if you can submit it if anything is Ok. Thank you[[BR]]

Thanks & regards, Christine

comment:3 by chrisclaydon, 15 years ago

Submitted patch on behalf of Christine Bao:

http://trac.osgeo.org/mapguide/changeset/4227

comment:4 by christinebao, 15 years ago

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.