Opened 15 years ago

Closed 15 years ago

#1075 closed enhancement (fixed)

GetNativeErrorCode

Reported by: Aleck Owned by: Aleck
Priority: low Milestone:
Component: General Version:
Severity: trivial Keywords:
Cc: External ID:

Description

This is to implement GetNativeErrorCode for MgFdoException class. See RFC 79 for details

Attachments (1)

2.patch​ (9.6 KB ) - added by Aleck 15 years ago.
patch for the ticket

Download all attachments as: .zip

Change History (7)

by Aleck, 15 years ago

Attachment: 2.patch​ added

patch for the ticket

comment:1 by traianstanev, 15 years ago

This exposes the new API introduced in FDO RFC 37:

​http://trac.osgeo.org/fdo/wiki/FDORfc37

comment:2 by tomfukushima, 15 years ago

Hi Aleck, Thanks for the 2.patch file, here are my review comments:

Format: first change in FdoException.cpp (line 30): put "m_nativeErrorCode(0)" on the next line.

Missing documentation: FdoException.h (line 79): need to add documentation for the nativeErrorCode argument.

Thanks Tom

comment:3 by tomfukushima, 15 years ago

Traian submitted with r4178 r4179.

Aleck, please make the changes I state above in my previous comments and I will submit the patch. thanks

comment:4 by traianstanev, 15 years ago

I applied the two suggested changes.

comment:5 by jbirch, 15 years ago

Version: 2.0.2

Sounds like this is done; can it be closed?

comment:6 by Aleck, 15 years ago

Resolution: → fixed
Status: new → closed
Note: See TracTickets for help on using tickets.