One error happened when setting Space as Log Delimiter.

[christinebao]

Steps to reproduce:

1. Log in Site Administrator
   
2. Configure Logs->Set Space as Log Delimiter->Save
   

One error happened:
Invalid argument(s):[1] =""The string was trimmed and it's size now differs from the original.

Diagnosis:
This defect is caused by a submission on Oct 14, 2006 about Configuration.cpp, Revision r883: MG408 (Security: Web Admin vulnerable to cross-site scripting attacks). It added a check when validate configuration and space is not allowed.

Fix:
It's unnecessary to filter space.

[christinebao]

Attach patch for fixing.

[tomfukushima]

Update summary by putting a r in front of the 883 so that clicking on it takes us to the revision.

[trevorwekel]

Hi Christine,

I would simply remove the CheckSpacesAtBeginEnd() call from the code instead of commenting it out.

Did you also validate all calls to CheckReservedCharacters() to ensure that removing the space check would have no side effects?

[christinebao]

Thank you Trevor.

I checked all calls to CheckReservedCharacters(), there are:

1. ResourceIdentifier.cpp
   

void MgResourceIdentifier::CheckRepositoryName()
{

...

MgUtil::CheckSpacesAtBeginEnd(m_repositoryName);
MgUtil::CheckReservedCharacters(m_repositoryName, MgReservedCharacterSet::Name);

...

}
void MgResourceIdentifier::CheckPath()
{

...

MgUtil::CheckSpacesAtBeginEnd(m_path);
MgUtil::CheckReservedCharacters(m_path, MgReservedCharacterSet::Path);
MgUtil::CheckReservedCharacters(m_path, L"", false);
MgUtil::CheckReservedCharacters(m_path, L" /", false);
MgUtil::CheckReservedCharacters(m_path, L"/ ", false);
MgUtil::CheckSlashAtBeginEnd(m_path);

...

}
void MgResourceIdentifier::CheckName()
{

...

MgUtil::CheckSpacesAtBeginEnd(m_name);
MgUtil::CheckReservedCharacters(m_name, MgReservedCharacterSet::Name);

...

}
void MgResourceIdentifier::CheckType(CREFSTRING repositoryType,

CREFSTRING resourceType)

{

...

MgUtil::CheckSpacesAtBeginEnd(resourceType);
MgUtil::CheckReservedCharacters(resourceType, MgReservedCharacterSet::Name);

...

}
Interesting, they all have MgUtil::CheckSpacesAtBeginEnd() before MgUtil::CheckReservedCharacters().

2. Configuration.cpp
   

void MgConfiguration::ValidateValue(CREFSTRING section, CREFSTRING property,

CREFSTRING value)

{

...
MgUtil::CheckReservedCharacters(value, sm_reservedCharacters);
MgUtil::CheckReservedCharacters(property, sm_reservedCharacters);
MgUtil::CheckReservedCharacters(section, sm_reservedCharacters);
...

}
To minimize the change, I prefer to add MgUtil::CheckSpacesAtBeginEnd() for property and section.

Please see the new attached patch ​http://trac.osgeo.org/mapguide/attachment/ticket/1057/RemoveSpaceCheck%28II%29.patch.

It's appreciated if someone could submit it :)

Replying to trevorwekel:

Hi Christine,

I would simply remove the CheckSpacesAtBeginEnd() call from the code instead of commenting it out.

Did you also validate all calls to CheckReservedCharacters() to ensure that removing the space check would have no side effects?

[christinebao]

The patch is submitted by Leaf. Thanks.