Opened 10 years ago

Closed 10 years ago

#980 closed defect (fixed)

WinGRASS shouldn't use Internet Explorer as a default browser

Reported by: marisn Owned by: grass-dev@…
Priority: normal Milestone: 6.4.0
Component: Packaging Version: svn-releasebranch64
Keywords: wingrass Cc:
CPU: x86-32 Platform: MSWindows Vista

Description

Current WinGRASS launcher sets GRASS_HTML_BROWSER to Internet Explorer and thus doesn't respect users preferences. When it gets changed to explorer, g.manual (and thus gis.m and wxgui) open manuals in users preferred browser (i.e. new tab in Firefox) and user doesn't have to hack around with env settings.

GRASS_HTML_BROWSER=explorer

Note missing quotes or path, as explorer.exe normally resides in PATH (C:\windows) and gets called from shell script g.manual.

Tested on WinGRASS-6.4.SVN-r41233-1 running on Windows Vista.

Change History (5)

comment:1 Changed 10 years ago by hamish

Keywords: wingrass added

see previous attempts in

http://trac.osgeo.org/osgeo4w/ticket/86

and

source:grass/trunk/mswindows/GRASS-Installer.nsi@41256#L535

help required to fix the FIXME.

Hamish

ps- please tag all WinGrass bugs with the "wingrass" keyword so they show up on the errata page.

comment:2 in reply to:  1 ; Changed 10 years ago by hellik

Replying to hamish:

see previous attempts in

http://trac.osgeo.org/osgeo4w/ticket/86

and

source:grass/trunk/mswindows/GRASS-Installer.nsi@41256#L535

help required to fix the FIXME.

ReadRegStr? $R0 HKCR "http\shell\open\command" (in the NSIS-script) should give the path to default browser (ie, firefox, opera or whatever).

Helmut

comment:3 in reply to:  2 ; Changed 10 years ago by marisn

Replying to hellik:

ReadRegStr? $R0 HKCR "http\shell\open\command" (in the NSIS-script) should give the path to default browser (ie, firefox, opera or whatever).

Helmut

Your' doing it wrong. GRASS should not hardcode or try to guess current default browser. Let Windows handle it. If user changes default Windows browser, GRASS will use new one instead of old one.

There's an issue with current approach - when user opens GRASS help in current WinGRASS within Internet Explorer, it's blocking wxgui command output till IE window gets closed. If GRASS_HTML_BROWSER is set to "explorer", then command output is not blocked.

comment:4 in reply to:  3 Changed 10 years ago by hellik

Replying to marisn:

Replying to hellik:

ReadRegStr? $R0 HKCR "http\shell\open\command" (in the NSIS-script) should give the path to default browser (ie, firefox, opera or whatever).

Helmut

Your' doing it wrong. GRASS should not hardcode or try to guess current default browser. Let Windows handle it. If user changes default Windows browser, GRASS will use new one instead of old one.

There's an issue with current approach - when user opens GRASS help in current WinGRASS within Internet Explorer, it's blocking wxgui command output till IE window gets closed. If GRASS_HTML_BROWSER is set to "explorer", then command output is not blocked.

done in r41428, r41429, r41430.

tested a little bit with self compiled grass64, grass65, grass7. please test the nightly builds.

Helmut

comment:5 Changed 10 years ago by marisn

Resolution: fixed
Status: newclosed

Works just fine - GRASS documentation for me opens in new Firefox tab :) Changing default Windows web browser immediately affects also GRASS (as it should be). As a reporter I take my freedom to close this bug. If anybody notices something bad - feel free to reopen it.

Note: See TracTickets for help on using tickets.