Opened 10 years ago

Closed 10 years ago

#974 closed enhancement (fixed)

[Patch] add option to d.vect to make symbol size proportionate to square root of size_column

Reported by: mlennert Owned by: grass-dev@…
Priority: normal Milestone: 7.0.0
Component: Display Version: unspecified
Keywords: Cc:
CPU: Unspecified Platform: Unspecified

Description

The attached patch adds a flag to d.vect to use the square root of the size_column values. This allows to make the surface of circles instead of their heights proportionate to the size value.

I did not want to commit immediately as I saw that Hamish was working on d.vect. BTW thanks for allowing to scale the size_column value.

Moritz

Attachments (1)

dvect_sqrt_patch.diff (10.7 KB) - added by mlennert 10 years ago.

Download all attachments as: .zip

Change History (3)

Changed 10 years ago by mlennert

Attachment: dvect_sqrt_patch.diff added

comment:1 Changed 10 years ago by hamish

(trac is logging me out every 5 minutes and it's driving me nuts!)

Hi,

I'm fine with the patch, a couple of comments though,

  • patches are much easier to review if they are kept to just the change you are talking about. ie gratuitous whitespace changes should be put in another patch if at all. signal:noise ratios & wasted time ...
  • please don't run the indent script unless you've added a bunch of new code which needs it. see the comments in the SUBMITTING file.
  • if using sqrt() please #include <math.h>
  • sqrt_flag->description: please split into two parts: short description on flag->label= line and "i.e." on flag->description= line (it becomes the tooltip).

non-specific comments-

  • I worry that the d.vect interface is becoming like a 747 cockpit for new users. So many controls it becomes overwhelming. the solution I guess is good use of tabs and specific task wrapper scripts (eg addons d.stations and d.varea).
  • now that d.vect has support for sizecol, rgbcol, widthcol, zcolor, etc, what is left for d.thematic.linepoint to do?

cheers, Hamish

comment:2 in reply to:  1 Changed 10 years ago by mlennert

Resolution: fixed
Status: newclosed

Replying to hamish:

I'm fine with the patch, a couple of comments though,

  • patches are much easier to review if they are kept to just the change you are talking about. ie gratuitous whitespace changes should be put in another patch if at all. signal:noise ratios & wasted time ...
  • please don't run the indent script unless you've added a bunch of new code which needs it. see the comments in the SUBMITTING file.

Sorry, thought indent should always be run. But understand the point and won't do it again ;-)

  • if using sqrt() please #include <math.h>
  • sqrt_flag->description: please split into two parts: short description on flag->label= line and "i.e." on flag->description= line (it becomes the tooltip).

I've just committed a corrected version of the patch to trunk.

Closing this and responding to the other issues on the mailing list.

Moritz

Note: See TracTickets for help on using tickets.