Opened 13 years ago

Closed 13 years ago

#839 closed defect (fixed)

wxGUI: About GRASS menu item broken

Reported by: hamish Owned by: martinl
Priority: major Milestone: 6.5.0
Component: wxGUI Version: svn-develbranch6
Keywords: Cc: grass-dev@…
CPU: x86-64 Platform: Linux

Description

Hi

in the 6.5 wxGUI if I do Help -> About GRASS GIS I get this error in the layer manager output tab:

Traceback (most recent call last):
  File "/usr/src/grass/svn/grass65/dist.x86_64
-unknown-linux-gnu/etc/wxpython/wxgui.py", line 554, in
OnAboutGRASS

win = AboutWindow(self)
  File "/usr/src/grass/svn/grass65/dist.x86_64
-unknown-linux-gnu/etc/wxpython/gui_modules/help.py", line
406, in __init__

transwin     = self.PageTranslators()
  File "/usr/src/grass/svn/grass65/dist.x86_64
-unknown-linux-gnu/etc/wxpython/gui_modules/help.py", line
601, in PageTranslators

label = name))
  File "/usr/lib/python2.5/site-
packages/wx-2.8-gtk2-unicode/wx/_controls.py", line 1136, in
__init__

_controls_.StaticText_swiginit(self,_controls_.new_StaticTex
t(*args, **kwargs))
UnicodeDecodeError
:
'ascii' codec can't decode byte 0xc3 in position 1: ordinal
not in range(128)

?, Hamish

Attachments (1)

about_translators.png (52.6 KB ) - added by hamish 13 years ago.
garbage in .csv tabs, missing Translators tab

Download all attachments as: .zip

Change History (13)

comment:1 by cmbarton, 13 years ago

It looks like this could be fixed in the most up-to-date svn version of 6.5. When I look at line 601 it is different that the line reported in this error.

Michael

comment:2 by hamish, 13 years ago

nope, still broken today. Now it says line 550, 409, 604, 1136 respectively.

comment:3 by cmbarton, 13 years ago

I found the location but have no idea why you are getting an error.

I also found out that on the Mac these new files translator.cvs and contributor.cvs are not getting moved to $GISBASE/etc to be found by About GRASS. I moved them manually to test and still got no error. There is nothing odd about the code.

Has anyone else had an error with About GRASS?

Michael

in reply to:  2 ; comment:4 by marisn, 13 years ago

Replying to hamish:

nope, still broken today. Now it says line 550, 409, 604, 1136 respectively.

Could this be locale-dependent issue? Michael is using en_US locale and thus all unicode/anycode text == ascii, which may not be true for other locales. Just guessing without reading code.

comment:5 by marisn, 13 years ago

Ah. Sorry. Pasted reply without testing. Michael:

export LC_ALL=de_DE
export LANG=de_DE
g.gui gui=wxpython

in reply to:  4 comment:6 by hamish, 13 years ago

Replying to marisn:

Could this be locale-dependent issue? Michael is using en_US locale and thus all unicode/anycode text == ascii, which may not be true for other locales. Just guessing without reading code.

perhaps, but I don't think so. I'm pretty sure the workstation I was testing on before is set up as LANG=C, and on a second machine here I'm a little surprised to see it is actually set to en_NZ instead of C or en_US. (usually it's just less trouble that way, and dealing with the spelling differences isn't a big deal, I just resolve myself to spelling poorly in both contexts ;)

On this second machine it works -- same debian version, only difference AFAIK is 32bit P4 instead of 64bit AMD. shrug. does it fail for anyone else? ubuntu users?

I also found that the 2 .csv files were missing, but the translators and contributers tabs are missing unless I drag the window wider. also the translators tab is open upon launch, but the info one should be. also I find scrolling with the mouse wheel down the gpl and authors list that the text is highly jumpy. is "contributers" redundant; shouldn't we just take care to merge that into Authors? (?)

Hamish

comment:7 by hamish, 13 years ago

_controls_.StaticText_swiginit(self,_controls_.new_StaticTex
t(*args, **kwargs))
UnicodeDecodeError
:
'ascii' codec can't decode byte 0xc3 in position 1: ordinal
not in range(128)

Ok maybe I can expand on Maris's theory. What if the translators.csv file has unicode symbols in it, but my LANG=C monolanguage install is too ignorant to deal with that?

I see non-ascii chars in the names of the Vietnamese and Czech translators. I bet if I anglify those it'll work.

Hamish

in reply to:  7 comment:8 by martinl, 13 years ago

Cc: grass-dev@… added
Owner: changed from grass-dev@… to martinl
Status: newassigned

Replying to hamish:

> _controls_.StaticText_swiginit(self,_controls_.new_StaticTex
> t(*args, **kwargs))
> UnicodeDecodeError
> :
> 'ascii' codec can't decode byte 0xc3 in position 1: ordinal
> not in range(128)

Ok maybe I can expand on Maris's theory. What if the translators.csv file has unicode symbols in it, but my LANG=C monolanguage install is too ignorant to deal with that?

I see non-ascii chars in the names of the Vietnamese and Czech translators. I bet if I anglify those it'll work.

Right, hopefully fixed in r40034.

Martin

comment:9 by hamish, 13 years ago

Martin:

Right, hopefully fixed in r40034.

nice, it now launches.

still todo:

  • the stuttering effect is still quite bad for all scrolling pages, leaving garbage in its wake for the new .csv tabs only. see attached screenshot
  • you'll notice in that screenshot that the Translators tab is missing. if the widget used to make the tabs doesn't have <- arrows -> to move onto extra tabs, the only thing I can think of is to make the default window size a bit wider. On this one machine it has to be 600px wide for all tabs to display. I think on the other machine I tried it on the number was about 640px. I guess it depends on local font size.
  • the version screen should come up first when you open the window, not the translators list.

thanks, Hamish

by hamish, 13 years ago

Attachment: about_translators.png added

garbage in .csv tabs, missing Translators tab

in reply to:  9 ; comment:10 by martinl, 13 years ago

Replying to hamish:

still todo:

  • the stuttering effect is still quite bad for all scrolling pages, leaving garbage in its wake for the new .csv tabs only. see attached screenshot

It's seems to be a wxPython bug.

  • you'll notice in that screenshot that the Translators tab is missing. if the widget used to make the tabs doesn't have <- arrows -> to move onto extra tabs, the only thing I can think of is to make the default window size a bit wider. On this one machine it has to be 600px wide for all tabs to display. I think on the other machine I tried it on the number was about 640px. I guess it depends on local font size.

done in r40056.

  • the version screen should come up first when you open the window, not the translators list.

should be done automatically, in r40057 is called SetSelection explicitly.

Martin

in reply to:  10 comment:11 by hamish, 13 years ago

Replying to hamish:

  • the stuttering effect

Replying to martinl:

It's seems to be a wxPython bug.

ok, will ignore.

  • you'll notice in that screenshot that the Translators tab

is missing.

done in r40056.

now it's obvious; thanks.

  • the version screen should come up first when you open

the window, not the translators list.

should be done automatically, in r40057 is called SetSelection explicitly.

now works for me, thanks.

Hamish

comment:12 by martinl, 13 years ago

Resolution: fixed
Status: assignedclosed
Note: See TracTickets for help on using tickets.