Opened 15 years ago
Closed 10 years ago
#721 closed defect (fixed)
r.li.setup: don't modify the WIND file
Reported by: | hamish | Owned by: | |
---|---|---|---|
Priority: | normal | Milestone: | 6.4.4 |
Component: | Raster | Version: | 6.4.0 RCs |
Keywords: | r.li, g.region, r.li.setup | Cc: | |
CPU: | All | Platform: | All |
Description
Hi,
when you create a sampling window with the mouse in r.li.setup it changes the current region. It should act like v.digit (tcl version) and only do that internally/in memory or by using GRASS_REGION or WIND_OVERRIDE.
Hamish
Change History (5)
comment:1 by , 13 years ago
Keywords: | g.region added |
---|---|
Milestone: | 6.4.0 → 6.4.3 |
follow-up: 3 comment:2 by , 11 years ago
Keywords: | r.li.setup added |
---|
comment:3 by , 11 years ago
Replying to hamish:
r.li.setup ... the future of it is for trunk? Was someone working on a python upgrade?
Luca D's prototype is there:
trunk/gui/wxpython/rlisetup
See also: http://grass.osgeo.org/grass70/manuals/g.gui.rlisetup.html
comment:4 by , 11 years ago
Milestone: | 6.4.3 → 6.4.4 |
---|
Hi, this is now complete in devbr6.
trunk is continued in #421. backport to relbr64 is todo.
One remaining thing to check for G6 r.li.setup is if there are places in the tcl code which need "quoting" around filename variables which may contain spaces. (e.g. path to temp files)
If regular tcl variables are ok(?) there are still some exec
statements which could need checking.
(Another thing to check is that temp files in the r.li.setup tcl code always get written into a temp dir instead of the pwd
)
Hamish
comment:5 by , 10 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
Hi,
Besides adding WIND_OVERRIDE, I have started cleaning up the many unquoted variables in r.li.setup, and replacing tiny tmp files with shell script backticks, but before going too far wonder what the future of it is for trunk? Was someone working on a python upgrade?
I'd note it uses Xmons, shell scripts, tcltk, and IIRC unix sockets(?), so not especially tuned for grass7.
thanks, Hamish