Opened 10 years ago

Closed 6 years ago

#721 closed defect (fixed)

r.li.setup: don't modify the WIND file

Reported by: hamish Owned by: grass-dev@…
Priority: normal Milestone: 6.4.4
Component: Raster Version: 6.4.0 RCs
Keywords: r.li, g.region, r.li.setup Cc:
CPU: All Platform: All

Description

Hi,

when you create a sampling window with the mouse in r.li.setup it changes the current region. It should act like v.digit (tcl version) and only do that internally/in memory or by using GRASS_REGION or WIND_OVERRIDE.

Hamish

Change History (5)

comment:1 Changed 8 years ago by hamish

Keywords: g.region added
Milestone: 6.4.06.4.3

comment:2 Changed 7 years ago by hamish

Keywords: r.li.setup added

Hi,

Besides adding WIND_OVERRIDE, I have started cleaning up the many unquoted variables in r.li.setup, and replacing tiny tmp files with shell script backticks, but before going too far wonder what the future of it is for trunk? Was someone working on a python upgrade?

I'd note it uses Xmons, shell scripts, tcltk, and IIRC unix sockets(?), so not especially tuned for grass7.

thanks, Hamish

comment:3 in reply to:  2 Changed 7 years ago by neteler

Replying to hamish:

r.li.setup ... the future of it is for trunk? Was someone working on a python upgrade?

Luca D's prototype is there:

trunk/gui/wxpython/rlisetup

See also: http://grass.osgeo.org/grass70/manuals/g.gui.rlisetup.html

comment:4 Changed 6 years ago by hamish

Milestone: 6.4.36.4.4

Hi, this is now complete in devbr6.

trunk is continued in #421. backport to relbr64 is todo.

One remaining thing to check for G6 r.li.setup is if there are places in the tcl code which need "quoting" around filename variables which may contain spaces. (e.g. path to temp files) If regular tcl variables are ok(?) there are still some exec statements which could need checking.

(Another thing to check is that temp files in the r.li.setup tcl code always get written into a temp dir instead of the pwd)

Hamish

comment:5 Changed 6 years ago by neteler

Resolution: fixed
Status: newclosed

AFAIK fixed in the rewrite in trunk (backported to G6 in r59304 and r59305).

Closing here, discussion continued in bug #1214.

Note: See TracTickets for help on using tickets.