Opened 10 years ago

Closed 7 years ago

#715 closed defect (fixed)

OSGeo4W patch for DLLs

Reported by: neteler Owned by: grass-dev@…
Priority: normal Milestone: 6.4.0
Component: Default Version: 6.4.0 RCs
Keywords: wingrass, osgeo4w Cc: jef
CPU: All Platform: MSWindows XP

Description

Attached patch was submitted by Juergen Fischer, please review.

Attachments (1)

dll_osgeo4w_fixes.diff (1.4 KB) - added by neteler 10 years ago.
DLL patch

Download all attachments as: .zip

Change History (10)

Changed 10 years ago by neteler

Attachment: dll_osgeo4w_fixes.diff added

DLL patch

comment:1 Changed 10 years ago by neteler

Cc: jef added

comment:2 in reply to:  description Changed 10 years ago by glynn

Replying to neteler:

Attached patch was submitted by Juergen Fischer, please review.

Is there some reason that Shlib.make and Stlib.make can't use ARCH_CMD_OBJS, so that Makefiles can just override MOD_OBJS if they don't want the default?

Failing that, Lib.make should use similar logic to Rules.make, i.e. only define the variables if they aren't already defined.

Either way, Lib.make should not contain references to specific files (fmode.o and dllmain.o).

comment:3 Changed 10 years ago by neteler

jef: any suggestions for us?

comment:4 Changed 10 years ago by jef

The point is just that the DLLs need to be linked with dllmain.o and the executables with fmode.o.

comment:5 Changed 10 years ago by neteler

Keywords: osgeo4w added

Jef, is the patch still needed?

comment:6 Changed 9 years ago by neteler

Related (?) fix in G7: r43279

comment:7 Changed 8 years ago by hamish

still relevant?

comment:8 Changed 7 years ago by neteler

See also ticket #469

comment:9 Changed 7 years ago by neteler

Resolution: fixed
Status: newclosed

Since no user complaints have been collected, closing for now.

(See also GRASS 6.4.svn (r35767, r35769) and 6.4.0svn (r35768, r35770) from #469)

Note: See TracTickets for help on using tickets.