Opened 16 years ago
Last modified 6 years ago
#562 new enhancement
patch proposal: do not show delimiters for empty labels in case of multiple cats per feature
| Reported by: | mlennert | Owned by: | |
|---|---|---|---|
| Priority: | normal | Milestone: | 7.6.2 |
| Component: | Default | Version: | svn-trunk |
| Keywords: | Cc: | adershowitz@… | |
| CPU: | Unspecified | Platform: | Unspecified |
Description
The attached patch (against svn7) slightly modifies d.vect in that it only displays delimiters ("/") for those category values where label values actually exist. I attache two screenshots to make clearer what the patch does.
I would just submit the patch without posting, but I'm not sure if some people find it important to see the existance of null values for some categories. However, if no one objects, I'll commit.
Moritz
Attachments (3)
Change History (13)
by , 16 years ago
| Attachment: | d.vect_attr.diff.gz added |
|---|
by , 16 years ago
| Attachment: | without_patch.png added |
|---|
by , 16 years ago
| Attachment: | with_patch.png added |
|---|
comment:1 by , 16 years ago
comment:2 by , 16 years ago
I think that it really depends on the data. For example, if you were doing samples at several locations once a month, but a few of the actual samples got lost in processing, then I would say that you are correct that missing data should be shown. On the other hand if the data is "missing" because it is the result of a query, ("select where value > 10" or "select where date < 2007-01-01") then you intentionally don't want to show some data, and having those slashes doesn't show any useful information. I would argue that if you actually are missing data, then it should be entered into the database as missing (-999, "M" whatever is appropriate for the type of data), rather then just leaving it blank. Perhaps the best answer would be to a flag for which behavior is desired. I would also propose that the user should be able to select what delimiter is used. "/" is not a bad choice for the default, but perhaps the user wants "\n" instead? That way the labels are not a cluttered in some cases. Another flag for d.vect?
comment:3 by , 9 years ago
| Milestone: | 7.0.0 → 7.0.5 |
|---|
comment:4 by , 8 years ago
| Milestone: | 7.0.5 → 7.3.0 |
|---|
comment:7 by , 7 years ago
| Milestone: | 7.4.1 → 7.4.2 |
|---|
comment:8 by , 6 years ago
| Milestone: | 7.4.2 → 7.6.0 |
|---|
All enhancement tickets should be assigned to 7.6 milestone.
what's the command line option to do that? I'm not sure I know what that does.
my gut feeling is that those empty delimiters actually do show information: positional. if you remove them and only one field has a value, which field did it come from, a, b, or c?
Hamish