Opened 12 years ago

Closed 12 years ago

#44 closed task (fixed)

./configure: cosmetics

Reported by: hamish Owned by: grass-dev@…
Priority: trivial Milestone: 6.4.0
Component: Default Version: svn-trunk
Keywords: Cc:
CPU: Unspecified Platform: Unspecified

Description

Hi,

for costmetic reasons we should reorder some items in the the yes/no ./configure summary.

Cairo support should be moved up (the rest of the list is in alphabetical order.

"MacOS App" should be moved up to the top section along with shared libs and 64bitness.

Q: move LFS and/or NLS to the top section as well?

Attachments (1)

config.in_reorder.diff (1.9 KB) - added by neteler 12 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 12 years ago by neteler

please go ahead...

comment:2 Changed 12 years ago by hamish

A patch for configure.in is attached to the bug report, but I don't know the exact recipe to rebuild configure with autoconf 2.13. (include that in the config.in header comments?)

Also the patch lacks indenting cosmetics for MacOS App in the top section, it'll be spaced an extra char to the right. I don't know how to fix that.

Hamish

comment:3 Changed 12 years ago by neteler

Just run autoconf-2.13. I do it like this:

[neteler@localhost grass63]$ patch -p0 < /tmp/config.in_reorder.diff
patching file configure.in

[neteler@localhost grass63]$ autoconf-2.13
configure.in:587: warning: Cannot check for file existence when cross compiling
[neteler@localhost grass63]$

Indent-fixed patch uploaded.

Markus

Changed 12 years ago by neteler

Attachment: config.in_reorder.diff added

comment:4 Changed 12 years ago by martinl

Q: Should I wait with changes in python/wxwidgets or just to commit to SVN now?

comment:5 Changed 12 years ago by martinl

Sorry, I forgot to put reference -- #38

Martin

comment:6 Changed 12 years ago by hamish

Markus:

Just run autoconf-2.13. I do it like this:

$ patch -p0 < /tmp/config.in_reorder.diff
...
$ autoconf-2.13

Indent-fixed patch uploaded.

Ok, that's both very easy. Two problems-

  • I notice that after running autoconf2.13 there is an extra reference to *.$ac_ext,

??? should I have run 'make distclean' before autoconf2.13 or do our autoconf's differ?

--- configure   (revision 30045)
+++ configure   (working copy)
@@ -1014,7 +1014,7 @@
   if { (eval echo configure:1015: \"$ac_link\") 1>&5; (eval $ac_link) 2>&5; }; then
     for file in conftest.*; do
       case $file in
-      *.c | *.o | *.obj) ;;
+      *.$ac_ext | *.c | *.o | *.obj) ;;
       *) ac_cv_exeext=`echo $file | sed -e s/conftest//` ;;
       esac
     done
  • top section indenting now lines up but "yes|no" part for MacOSX App doesn't.
  Building shared libraries:   yes
  64bit support:               no
  OpenGL platform:             X11
  MacOSX application:         no

  NVIZ:                       yes

  BLAS support:               no
  C++ support:                yes
  Cairo support:              yes
  DWG support:                no

Martin:

Q: Should I wait with changes in python/wxwidgets or just to commit to SVN now? (#38)

because it's so trivial I don't see a reason not to combine them, but on the other hand this patch does not cause more than a few lines of change in configure (typically autoconf causes a huge patch) so it wouldn't be inefficient to do it by itself. shrug.

Outstanding question:

Q: move LFS and/or NLS to the top section as well?

Hamish

comment:7 Changed 12 years ago by neteler

Resolution: fixed
Status: newclosed

Submitted.

Note: See TracTickets for help on using tickets.