Opened 13 years ago

Last modified 3 years ago

#412 new enhancement

add bbox check to d.rast

Reported by: karme Owned by: grass-dev@…
Priority: trivial Milestone: 7.6.2
Component: Display Version: svn-trunk
Keywords: d.rast Cc:
CPU: Unspecified Platform: All

Description

patch applied

Attachments (2)

bbox.diff (2.0 KB) - added by karme 13 years ago.
patch against current 6.4 release branch
bbox2.diff (1.1 KB) - added by karme 13 years ago.
updated patch

Download all attachments as: .zip

Change History (16)

Changed 13 years ago by karme

Attachment: bbox.diff added

patch against current 6.4 release branch

comment:1 Changed 13 years ago by karme

Platform: UnspecifiedAll
Priority: majortrivial
Type: defectenhancement
Version: unspecifiedsvn-develbranch6

the description should read "patch attached"

comment:2 in reply to:  description Changed 13 years ago by glynn

Replying to karme:

There appear to be a couple of things wrong here:

  1. It assumes -o (or the lack of -n in 7.0). Without -o or with -n, a raster which doesn't overlap the current region should result in a solid rectangle in the map's null value colour.
  1. D_cell_draw_setup() is called unconditionally, but D_cell_draw_end() is only called if the raster is visible. These calls must be matched, i.e. either both must be called, or neither.

Apart from that, I would suggest making the patch against 7.0.

Changed 13 years ago by karme

Attachment: bbox2.diff added

updated patch

comment:3 Changed 13 years ago by karme

Attached updated patch addressing both issues.

comment:4 Changed 9 years ago by neteler

Milestone: 6.4.07.0.0
Version: svn-develbranch6svn-trunk

comment:5 Changed 8 years ago by neteler

Component: DefaultDisplay
Keywords: d.rast added

comment:6 Changed 6 years ago by martinl

Milestone: 7.0.07.0.5

comment:7 Changed 5 years ago by martinl

Still the issue?

comment:8 Changed 5 years ago by martinl

Milestone: 7.0.57.3.0

comment:9 Changed 5 years ago by martinl

Milestone: 7.3.07.4.0

Milestone renamed

comment:10 Changed 4 years ago by neteler

Milestone: 7.4.07.4.1

Ticket retargeted after milestone closed

comment:11 Changed 4 years ago by neteler

Milestone: 7.4.17.4.2

comment:12 Changed 3 years ago by martinl

Milestone: 7.4.27.6.0

All enhancement tickets should be assigned to 7.6 milestone.

comment:13 Changed 3 years ago by martinl

Milestone: 7.6.07.6.1

Ticket retargeted after milestone closed

comment:14 Changed 3 years ago by martinl

Milestone: 7.6.17.6.2

Ticket retargeted after milestone closed

Note: See TracTickets for help on using tickets.