Copy button on wxgrass function forms does not work

[brian]

Copy to clipboard button on wxgrass function forms, e.g.v.in.ascii, does not work. Cannot copy the command. Current Grass63 svn. O/S = Ubuntu 7.10 wxpython = 2.8.7.1 Happens

Same behaviour on Mandriva 2008.

[martinl]

Hi,

can you provide more detailed info? I cannot reproduce this behaviour (Debian GNU/Linux, Python 2.4, wxPython 2.8.7.1). Here copying to clipboard works. Martin

[brian]

Hi Martin Still no copy even with latest builds, i.e the copy button does nothing.

Using: Python 2.5.1 wxPython 2.8.7.1

Cheers Brian

[brian]

screenshot of v.in.dxf

[brian]

Using Ubuntu Hardy.

Still same error. Cannot copy to clipboard from any wxpython form. See attached screen shot:

[martinl]

Replying to brian:

Still same error. Cannot copy to clipboard from any wxpython form. See attached screen shot:

From attached screenshot I don't see anything strange. I don't fully understand what is broken.

• launch GUI dialog
• set required parameters
• 'Copy'
• e.g. paste data from clipboard to xterm, works
• close dialog -> clipboard empty

?

Martin

[brian]

Replying to martinl: The screenshot shows the form after the copy button is pressed. Although the bottom of the screenshot shows "copied to clipboard", there is nothing in the clipboard and no error message.

Brian

Replying to brian:

Still same error. Cannot copy to clipboard from any wxpython form. See attached screen shot:

From attached screenshot I don't see anything strange. I don't fully understand what is broken.

• launch GUI dialog
• set required parameters
• 'Copy'
• e.g. paste data from clipboard to xterm, works
• close dialog -> clipboard empty

?

Martin

[msieczka]

On Debian testing, amd64, python-wxgtk 2.8.8.1 after pressing 'Copy' button there is also nothing in the clipboard that could be pasted into e.g. a terminal with "right click > paste", but I can paste with middle mouse button (both develbranch6 and trunk).

[glynn]

Replying to msieczka:

On Debian testing, amd64, python-wxgtk 2.8.8.1 after pressing 'Copy' button there is also nothing in the clipboard that could be pasted into e.g. a terminal with "right click > paste", but I can paste with middle mouse button (both develbranch6 and trunk).

That's due to the use of wx.TheClipboard.UsePrimarySelection(True) in mainFrame.OnCopy(). source:/grass/trunk/gui/wxpython/gui_modules/menuform.py@32365#L817​

This causes the data to be copied to the primary selection rather than the clipboard. An explicit "copy" operation should use the clipboard (this is how Ctrl-C or Ctrl-Insert normally behave); the primary selection is for the selection.

[cmbarton]

Works on Mac in trunk and no changes to copy AFAIK. Is this still an issue in other contexts?

[brian]

Still an issue on Ubuntu 8.04. Confirm that copy button on form does not copy data to clipboard, however ctrl-middle mouse button will paste to terminal. IMHO this should work the same as the tcltk gui and allow paste from ctrl-v or right click.

[msieczka]

Also still an issue on Debian testing amd64 with a recent develbranch6 r33280.

[cmbarton]

I commented out the line wx.TheClipboard.UsePrimarySelection(True) in r35120 (develbranch_6). It works fine on the Mac. Please test to see if it works OK on Linux now. If so, we can backport to releasebranch and grass 7.

[msieczka]

Replying to cmbarton:

I commented out the line wx.TheClipboard.UsePrimarySelection(True) in r35120 (develbranch_6). It works fine on the Mac. Please test to see if it works OK on Linux now. If so, we can backport to releasebranch and grass 7.

Works fine on Debian testing too. Thanks.

[cmbarton]

Now fixed in trunk and releasebranch