Opened 10 months ago

Closed 6 weeks ago

Last modified 6 weeks ago

#3964 closed enhancement (fixed)

Update browser list to check for chrome

Reported by: jidanni Owned by: grass-dev@…
Priority: trivial Milestone: 7.8.3
Component: Startup Version: unspecified
Keywords: Cc:
CPU: Unspecified Platform: Unspecified

Description

https://github.com/OSGeo/grass/blob/master/lib/init/grass.py#L678 mentions firefox, but not chrome or chromium.

And maybe it needs to do os.getenv('BROWSER') also.

Change History (6)

comment:1 in reply to:  description ; Changed 10 months ago by neteler

Replying to jidanni:

https://github.com/OSGeo/grass/blob/master/lib/init/grass.py#L678 mentions firefox, but not chrome or chromium.

Ok, please try

https://github.com/OSGeo/grass/pull/201

And maybe it needs to do os.getenv('BROWSER') also.

No idea, do other devs have an opinion?

comment:2 Changed 10 months ago by jidanni

Everybody knows about $BROWSER.

$ w3m -dump https://wiki.archlinux.org/index.php/Environment_variables | grep -C 2 BROWSER

  • BROWSER contains the path to the web browser. Helpful to set in an
    interactive shell configuration file so that it may be dynamically altered
    depending on the availability of a graphic environment, such as X:

if [ -n "$DISPLAY" ]; then
    export BROWSER=firefox
else
    export BROWSER=links
fi

https://unix.stackexchange.com/a/213369/179494 etc.

comment:4 in reply to:  1 Changed 10 months ago by neteler

Replying to neteler:

https://github.com/OSGeo/grass/pull/201

Merged and backported!

comment:5 Changed 10 months ago by neteler

Milestone: 7.8.3

comment:6 Changed 6 weeks ago by wenzeslaus

Resolution: fixed
Status: newclosed

The Chrome/Chromium part was resolved in PR:201, so closing as fixed.

I created a new issue on GitHub for the BROWSER suggestion: GitHub Issue 890.

Last edited 6 weeks ago by wenzeslaus (previous) (diff)
Note: See TracTickets for help on using tickets.