Opened 6 years ago

Closed 6 years ago

#3769 closed defect (fixed)

[testsuite] Do not hardcode the path of the GRASSSRC

Reported by: pmav99 Owned by: grass-dev@…
Priority: normal Milestone:
Component: Tests Version: svn-trunk
Keywords: Cc:
CPU: Unspecified Platform: Unspecified

Description

The hardcoded path makes it difficult to run the testsuite without modifying the configuration file. By using a relative path, anyone can run the testuite without any modifications.

Original PR: ​https://github.com/GRASS-GIS/grass-ci/pull/5 

Index: testsuite/examples/test_framework_GRASS_GIS_with_NC.conf
===================================================================
--- testsuite/examples/test_framework_GRASS_GIS_with_NC.conf	(revision 74152)
+++ testsuite/examples/test_framework_GRASS_GIS_with_NC.conf	(working copy)
@@ -3,7 +3,7 @@
 # name of binary:
 GRASSBIN=grass77
 # source code directory as full path:
-GRASSSRC="$HOME/software/grass77"
+GRASSSRC="$(realpath ../../)"
 # temporary grassdata directory
 GRASSDATA="$HOME/grassdata/tests-grassdata"

Change History (1)

comment:1 by neteler, 6 years ago

Resolution: → fixed
Status: new → closed

In 74158:

test_framework_GRASS_GIS_with_NC.sh: avoid hardcoded path; usage mesg cosmetics (fixes #3769)

Note: See TracTickets for help on using tickets.