Verbosity of g.extension when using the -f flag

[Nikos Alexandris]

In g.extension, in the def remove_extension() function, there is:

    if force:
        grass.verbose(_("List of removed files:"))
    else:
        grass.info(_("Files to be removed:"))

and

    if force:
        grass.message(_("Updating addons metadata file..."))
        remove_extension_xml(mlist)
        grass.message(_("Extension <%s> successfully uninstalled.") %
                      options['extension'])

This is not correct in my humble view. In case of using the -f flag, the messages will be emitted regardless of any successful or non-successful execution of the remove_extension_xml function which in turn can be misleading.

I suggest these messages to be integrated in the functions for which they report whatever they report. I have no solution to propose yet, but this ticket serves to highlight the problem.

[martinl]

Remove Milestone from Addons bugreports.

[Nikos Alexandris]

Also here: ​https://github.com/OSGeo/grass/blob/9d140ebe89995a8e698e1b9d19f18b7c7387b64c/scripts/g.extension/g.extension.py#L1401

Better to state something is done after it is done. Else, change the message.