Opened 5 years ago

Closed 5 years ago

#3746 closed defect (fixed)

Quouting of strings with white space in t.info breaks tests for temporal modules

Reported by: sbl Owned by: grass-dev@…
Priority: normal Milestone: 7.8.0
Component: Tests Version: svn-trunk
Keywords: temporal, t.info Cc:
CPU: All Platform: All

Description

When working on t.rast.aggregate, I noticed that tests fail du to quoting of strings in t.info.

Working on it...

Change History (6)

comment:1 by sbl, 5 years ago

Relevant files: 

temporal/t.connect/testsuite/test_distr_tgis_db_raster3d.py
temporal/t.connect/testsuite/test_distr_tgis_db_raster.py
temporal/t.connect/testsuite/test_distr_tgis_db_vector.py
temporal/t.info/testsuite/test.t.info.sh
temporal/t.merge/testsuite/test.t.merge.sh
temporal/t.rast3d.extract/testsuite/test_extract.py
temporal/t.rast3d.extract/testsuite/test.t.rast3d.extract.sh
temporal/t.rast.accdetect/testsuite/test_simple.py
temporal/t.rast.aggregate.ds/testsuite/test.t.rast.aggregate.ds.sh
temporal/t.rast.aggregate/testsuite/test_aggregation_absolute_parallel.py
temporal/t.rast.aggregate/testsuite/test_aggregation_absolute.py
temporal/t.rast.aggregate/testsuite/test_aggregation_relative.py
temporal/t.rast.contour/testsuite/test_convert.py
temporal/t.rast.extract/testsuite/test_extract.py
temporal/t.rast.gapfill/testsuite/test_gapfill.py
temporal/t.rast.import/testsuite/test_temporal_rast_import.py
temporal/t.rast.series/testsuite/test_series.py
temporal/t.rast.to.vect/testsuite/test_to_vect.py
temporal/t.vect.extract/testsuite/test_vect_extract.py
temporal/t.vect.observe.strds/testsuite/test.t.vect.observe.strds.layer_bug.sh
temporal/t.vect.observe.strds/testsuite/test.t.vect.observe.strds.relative.sh
temporal/t.vect.observe.strds/testsuite/test.t.vect.observe.strds.sh

comment:2 by sbl, 5 years ago

In 74054:

t.connect testsuite; fix info quotes; see #3746

comment:3 by sbl, 5 years ago

In 74055:

t.rast3d.extract testsuite; fix info quotes; see #3746

comment:4 by sbl, 5 years ago

In 74059:

more t.info quote fixes; see #3746

comment:5 by sbl, 5 years ago

In 74073:

add quotes around t.info strings; see #3746

comment:6 by sbl, 5 years ago

Resolution: → fixed
Status: new → closed

The rest of the test-errors in the temporal testsuites were not touched as they indicate other issues (e.g. related to Python 3, changed results, or errors in the test-code.)

Types of those errors are:

  • AssertionError: reference argument is not a string (in several tests)
  • grass.exceptions.FatalError: Wrong type of input A (in algebra tests)
  • AttributeError: 'NoneType' object has no attribute 'second' (in several tests related to datetime_math)
  • AssertionError: There is no map <b_2001_01_01_00> of type <raster> in the current mapset (t.rast.aggregate)
  • Process ended with non-zero return code t.remove(inputs=R, type='strds', flags=u'rf', quiet=True). See errors in the (error) output.
  • UnicodeEncodeError: 'ascii' codec can't encode character u'\xe9' in position 2: ordinal not in range(128)
Note: See TracTickets for help on using tickets.