r.neighborhoodmatrix: inverse meaning of -c flag in grass8

[mlennert]

This ticket is just there as a reminder that when grass8 comes out we should use the opportunity to inverse the meaning of the -c flag in r.neighborhoodmatrix to harmonize it with other modules.

-c should indicate: do not show column headers. Currently it indicates: show column headers.

[wenzeslaus]

That's fine with me, but you may also want to consider that:

1. r.neighborhoodmatrix is an addon module, so there is no guarantee of stable API linked with releases of GRASS GIS, i.e. you can change it anytime (Addons provide option to rapidly change, but in public and that's what makes them different from core.)

2. You can introduce two flags, one to show and one to hide the headers. For 7, one will be NOP and the other will show column header, for 8 it will be the reverse. So that people who care about heaving or not heaving the header can actually indicate it by a flag and their code will give the right result with both 7 and 8 versions of the module.

[mlennert]

I don't know why, but I completely missed that you had responded, Vaclav.

Replying to wenzeslaus:

That's fine with me, but you may also want to consider that:

1. r.neighborhoodmatrix is an addon module, so there is no guarantee of stable API linked with releases of GRASS GIS, i.e. you can change it anytime (Addons provide option to rapidly change, but in public and that's what makes them different from core.)

Even though I agree in principle, in practice I know that some people use addons also in scripts and changing the API can have consequences on these scripts, so I think we should be careful about this.

2. You can introduce two flags, one to show and one to hide the headers. For 7, one will be NOP and the other will show column header, for 8 it will be the reverse. So that people who care about heaving or not heaving the header can actually indicate it by a flag and their code will give the right result with both 7 and 8 versions of the module.

Good point. I'll think about this option.

[martinl]

Remove Milestone from Addons bugreports.