Opened 22 months ago

Last modified 15 months ago

#3525 new task

Removing the behavior of i.maxlik which add the output to input group

Reported by: spareeth Owned by: grass-dev@…
Priority: normal Milestone: 8.0.0
Component: Imagery Version: svn-trunk
Keywords: i.maxlik Cc:
CPU: Unspecified Platform: All

Description

The final result from i.maxlik is added to input group by default. which in my opinion is strange. I dont know if there is any reason behind this behaviour.

In the mapset nc_spm_08_grass7/landsat;

i.group group=lsat7_2000_NW subgroup=lsat7_2000_NW input=lsat7_2000_10,lsat7_2000_20,lsat7_2000_30,lsat7_2000_40,lsat7_2000_50
i.cluster group=lsat7_2000_NW subgroup=lsat7_2000_NW signaturefile=sig_cluster_lsat2000 classes=10 reportfile=rep_clust_lsat2000.txt
i.maxlik group=lsat7_2000_NW subgroup=lsat7_2000_NW  signaturefile=sig_cluster_lsat2000 output=lsat7_2000_cluster_10classes reject=lsat7_2002_cluster_reject
i.group lsat7_2000_NW -l
group <lsat7_2000_NW> references the following raster maps
-------------
<lsat7_2000_10@landsat>                   
<lsat7_2000_20@landsat>                   
<lsat7_2000_30@landsat>                   
<lsat7_2000_40@landsat>                   
<lsat7_2000_50@landsat>                   
<lsat7_2000_cluster_10classes@landsat>    
<lsat7_2002_cluster_reject@landsat>  

Would be better to remove this behaviour in future release.

Change History (8)

comment:1 Changed 15 months ago by veroandreo

+1!

It's a quite annoying to have to remove the classification and reject maps from the group in each new run, better leave optional to the user to add it if he/she wants it as an additional input layer.

comment:2 Changed 15 months ago by martinl

+0 Key point is that output maps are not added to subgroup (which is used by most of imagery modules for reading list of input maps).

comment:3 Changed 15 months ago by martinl

So you don't need to remove output maps from group in each new run...

comment:4 Changed 15 months ago by martinl

Component: DefaultImagery
Keywords: i.maxlik added
Type: enhancementtask

comment:5 in reply to:  3 ; Changed 15 months ago by veroandreo

Replying to martinl:

So you don't need to remove output maps from group in each new run...

Good! Thanks for clarification, Martin! I still prefer not to have classification results in the group, though ;)

comment:6 in reply to:  5 ; Changed 15 months ago by mmetz

Replying to veroandreo:

Replying to martinl:

So you don't need to remove output maps from group in each new run...

Good! Thanks for clarification, Martin! I still prefer not to have classification results in the group, though ;)

Assuming that imagery modules accept a group/subgroup as input that is not in the current mapset, the output can not be added to the input group if it is not in the current mapset.

The metadata of the output (datasource, description, comments) should in any case contain information about how this output has been generated: fully qualified input group/subgroup name, fully qualified input signature file name if appropriate, and other parameters used by i.maxlik.

comment:7 in reply to:  6 Changed 15 months ago by marisn

Replying to mmetz:

Replying to veroandreo: Assuming that imagery modules accept a group/subgroup as input that is not in the current mapset, the output can not be added to the input group if it is not in the current mapset.

This is a good argument. Still at the moment only library and i.group has been changed to allow reading group contents from other mapsets. See r73632 and r73633

This issue should be viewed together with signature files as those also are placed into the group/subgroup.

comment:8 Changed 15 months ago by mlennert

See also #2483.

Note: See TracTickets for help on using tickets.