Opened 5 years ago
Last modified 3 years ago
#3471 reopened defect
Custom dropdown control doesn’t recognize mouse events
| Reported by: | cmbarton | Owned by: | |
|---|---|---|---|
| Priority: | major | Milestone: | 7.6.2 |
| Component: | wxGUI | Version: | 7.2.2 |
| Keywords: | wxPython, dropdown control | Cc: | |
| CPU: | Unspecified | Platform: | MacOSX |
Description
A custom drop-down list control does not respond to mouse scroll and mouse down events in wxPython 3 and above. It does respond to arrow key events. While this might be fixable in the rather convoluted custom control code, It is not clear why this control is even needed now.
Look at g.mapset. Mapset name is a standard drop-down list and works fine. Location name is the custom control and does not. This control is used sporadically in only a few places. It would be best to replace it with a standard wxPython control.
Change History (11)
comment:1 by , 5 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
comment:2 by , 5 years ago
| Priority: | normal → major |
|---|---|
| Resolution: | fixed |
| Status: | closed → reopened |
I was wrong. This is still a problem. In fact, the dropdown menu is now invisible. See settings/grass working environment/change location and mapset. The change mapset control cannot be used at all. Upgrading to major (maybe should be critical) since it makes a set of functions completely unusable.
comment:4 by , 5 years ago
| Milestone: | → 7.2.4 |
|---|
comment:5 by , 5 years ago
I replaced MapsetSelect with simpler widget in r72754. Needs more testing, it's used in
- Settings - Change location and mapset/Change mapset
- Add multiple maps dialog
- in module dialogs, e.g. g.mapsets - allows multiple mapsets
comment:6 by , 5 years ago
Thanks. I will recompile as soon as I can, maybe tomorrow if all goes well, and test. If not tomorrow, then the beginning of next week.
comment:7 by , 5 years ago
I've compiled trunk and this seems to fix the problem. I tested on several modules and found no problems. I'm testing with wxPython 4.0.0. When this is back ported to 7.2 and 7.4 and tested, we can close. Thanks much.
comment:9 by , 4 years ago
| Resolution: | → fixed |
|---|---|
| Status: | reopened → closed |
comment:10 by , 4 years ago
| Milestone: | 7.2.4 → 7.6.2 |
|---|---|
| Resolution: | fixed |
| Status: | closed → reopened |
Reopening. I thought these were all fixed. But I recently found more of these drop downs in the analytical dialogs accessible from the display window menu bar. These include the profiler, histogrammer, bivariate scatterplot tool. If this pull down is controlled by a single piece of code somewhere for these modules, it can be easily fixed like the other instances. I'll move the milestone up to the current stable version too.
comment:11 by , 3 years ago
A PR with a fix has been made for #3502, with https://github.com/OSGeo/grass/pull/363.
This issue will likely also be solved by that fix.
Checking the new Mac binaries, this seems to be fixed in version 7.2.2. I will close unless I run into it again.