Opened 7 years ago
Last modified 6 years ago
#3336 new defect
r.viewshed max_distance always in meters
| Reported by: | annakrat | Owned by: | |
|---|---|---|---|
| Priority: | normal | Milestone: | 7.2.4 |
| Component: | Raster | Version: | svn-trunk |
| Keywords: | viewshed, units | Cc: | |
| CPU: | All | Platform: | All |
Description
r.viewshed manual says that max_distance option is entered in map units, but in fact, the value is compared to the return value of G_distance, which is always in meters.
So either we change the manual (simple, no change for the user), or we change the code (simple, but changes behavior).
Change History (7)
follow-up: 2 comment:1 by , 7 years ago
follow-up: 3 comment:2 by , 7 years ago
Replying to pvanbosgeo:
If opting for the second option, I would suggest, if possible, to include the option to set value in meters as well, or more in general, to include the option to set the unit.
I don't think that's necessary here, ideally max_distance should be in the map units, that's what everybody would expect, setting specific units just for max_distance doesn't add much to the usability in my opinion.
follow-up: 4 comment:3 by , 7 years ago
Replying to annakrat:
Replying to pvanbosgeo:
If opting for the second option, I would suggest, if possible, to include the option to set value in meters as well, or more in general, to include the option to set the unit.
I don't think that's necessary here, ideally max_distance should be in the map units, that's what everybody would expect, setting specific units just for max_distance doesn't add much to the usability in my opinion.
Can r.viewshed be run in latlon? In that case, being able to set the maximum distance in meters could make sense?
comment:4 by , 7 years ago
Replying to pvanbosgeo:
Replying to annakrat:
Replying to pvanbosgeo:
If opting for the second option, I would suggest, if possible, to include the option to set value in meters as well, or more in general, to include the option to set the unit.
I don't think that's necessary here, ideally max_distance should be in the map units, that's what everybody would expect, setting specific units just for max_distance doesn't add much to the usability in my opinion.
Can r.viewshed be run in latlon? In that case, being able to set the maximum distance in meters could make sense?
I believe so, in latlon it uses meters, so that should be clarified in the manual.
comment:7 by , 6 years ago
| Milestone: | → 7.2.4 |
|---|
If opting for the second option, I would suggest, if possible, to include the option to set value in meters as well, or more in general, to include the option to set the unit.