Opened 11 years ago

Closed 6 years ago

Last modified 6 years ago

#332 closed enhancement (fixed)

Uniform order for "at=" screen coordinates in d.* modules

Reported by: nikos Owned by: grass-dev@…
Priority: minor Milestone: 7.0.0
Component: Display Version: svn-trunk
Keywords: d.barscale, d.legend, d.text, d.graph Cc: nikos.alexandris@…
CPU: All Platform: All

Description

# from d.barscale help
at The screen coordinates for top-left corner of label ([0,0] is top-left of frame)

# from d.legend help
at Placement as percentage of screen coordinates (0,0 is lower left)

Is there a specific reason for not having those the same?

Change History (5)

comment:1 Changed 11 years ago by hamish

Milestone: 6.4.07.0.0

d.legend at= settings were designed to mimic d.frame's convention.

for GRASS7 these should be standardized. for GRASS 6 it is frozen.

see comments in grass64.svn/lib/display/cnversions.c if you want to look deeper.

Hamish

comment:2 in reply to:  1 ; Changed 11 years ago by glynn

Replying to hamish:

see comments in grass64.svn/lib/display/cnversions.c if you want to look deeper.

Note: that file has changed a great deal in 7.0 (and may well change further), so don't pay too much attention to anything contained in it.

In 7.0, the "U" coordinates aren't required to be cartographic coordinates, e.g. d.graph uses percentages (i.e. coordinates range from 0,0 to 100,100). Also, physical coordinates (pixels, points) are hardly used now by d.* commands. The only remaining vestige is that the conversion factor is often used for sizing text and certain other elements (e.g. symbols).

comment:3 in reply to:  2 ; Changed 6 years ago by nikos

Is this still valid in grass 7? The "--help"s of the two reported modules (above) describing "at=" still differ?

comment:4 Changed 6 years ago by hamish

Component: DefaultDisplay
CPU: UnspecifiedAll
Keywords: d.barscale d.legend d.text d.graph added
Platform: UnspecifiedAll
Resolution: fixed
Status: newclosed
Version: unspecifiedsvn-trunk

all d.* modules seem updated now to use the convention (0%,0%) of the display frame as meaning the lower-left.

Hamish

comment:5 in reply to:  3 Changed 6 years ago by nikos

Replying to nikos:

Is this still valid in grass 7? The "--help"s of the two reported modules (above) describing "at=" still differ?

Sorry, I wanted to... "!" not "?" in the end. They still differ "here":

d.barscale --help
..
at   The screen coordinates for top-left corner of label
                      (0,0) is lower-left of frame

and

d.legend --help
..
at   Size and placement as percentage of screen coordinates (0,0 is lower left)
               bottom,top,left,right
              options: 0-100

The "d.barscale" description referring to "top-left" is (still) confusing.

Note: See TracTickets for help on using tickets.