r.in.srtm: patch to support SRTM water bodies import (SWBD)

[stjo]

I developed an enhancement for r.in.srtm to import SRTM water bodies in the .raw format and .raw.zip format, e.g. from ​https://dds.cr.usgs.gov/srtm/version2_1/SWBD/ Internally, it uses r.in.bin and is activated by the flag 'w' for 'water'.

Maybe someone can check my changes and take a look if my python coding Style is ok. :)

[neteler]

enhancement patch

[lucadelu]

I updated the patch, but I'm not able to test it because there are no raw files in ​​https://dds.cr.usgs.gov/srtm/version2_1/SWBD/. In the zip files there are only shapefile.

[neteler]

Patch updated by lucadelu

[stjo]

I'm really sorry for the wrong link.

If you still want to test my changes, the correct link is: ​https://e4ftl01.cr.usgs.gov/SRTM/SRTMSWBD.003/2000.02.11/

[martinl]

All enhancement tickets should be assigned to 7.4 milestone.

[neteler]

Ticket retargeted after milestone closed

[lucadelu]

Replying to stjo:

I'm really sorry for the wrong link.

If you still want to test my changes, the correct link is: ​https://e4ftl01.cr.usgs.gov/SRTM/SRTMSWBD.003/2000.02.11/

Sorry I cannot access again to this link. It seems it requires special permission, I already authorized LP DAAC on my account.

[stjo]

USGS has changed the link, you can access the data now on:

• ​https://e4ftl01.cr.usgs.gov/MEASURES/SRTMSWBD.003/2000.02.11/

or

• ​https://e4ftl01.cr.usgs.gov//MODV6_Dal_D/SRTM/SRTMSWBD.003/2000.02.11/

[lucadelu]

GDAL doesn't support this format by default, reading a little bit more about the data it seems that is is only the line coast and they also provide shapefile for this dataset ​https://lta.cr.usgs.gov/srtm_water_body_dataset

I think the shapefile is more useful than raster, if you really need raster you can rasterize the vector.

[neteler]

Replying to lucadelu:

I think the shapefile is more useful than raster, if you really need raster you can rasterize the vector.

I think the idea is that their raster mask precisely matches what was used in the processing chain. to reach that with self-rasterized vector maps may lead to slightly different results.

[lucadelu]

In 72569:

r.in.srtm: added support to SRTM SWBD, see #3246

[rouault]

Support for opening SRTM SWBD in GDAL added per ​https://github.com/OSGeo/gdal/commit/a85292c5af40a48bf5b68ca36712b286ff2a95fb

[neteler]

Replying to lucadelu:

In 72569:

r.in.srtm: added support to SRTM SWBD, see #3246

Is this ticket done?

[martinl]

All enhancement tickets should be assigned to 7.6 milestone.

[lucadelu]

Replying to neteler:

Is this ticket done?

Yes, to me it seems done. Maybe one more test could useful

[lucadelu]

Closing, reopen if needed