shapelib/DBF driver: re-sync to GDAL/OGR needed

[neteler]

The DBF driver is based on lib/external/shapelib which has been derived from Shapelib provided through GDAL/OGR (ogr/ogrsf_frmts/).

The last sync was done in 2008, time to update again.

[mlennert]

Should this be done before the 7.2 release ?

[mmetz]

Done in trunk r69890. Unfortunately, more fixes were now needed to make it work outside GDAL, see updated README.

[rouault]

I've just resync'ed shapelib CVS from GDAL and make various fixes to compile in standalone mode (likely similar to yours). See ​http://lists.maptools.org/pipermail/shapelib/2016-December/000627.html

Looking at r69890, the following is incorrect:

+#define CPL_IGNORE_RET_VAL_INT(ret_val_int)    return

The purpose of this macro is to make the compiler not warn about the fact that we don't verify the return value of a function. The correct dummy implementation should be :

#define CPL_IGNORE_RET_VAL_INT(x) x

(see ​https://trac.osgeo.org/gdal/changeset/36680)

[mmetz]

Replying to rouault:

I've just resync'ed shapelib CVS from GDAL and make various fixes to compile in standalone mode (likely similar to yours). See ​http://lists.maptools.org/pipermail/shapelib/2016-December/000627.html

Looking at r69890, the following is incorrect:

+#define CPL_IGNORE_RET_VAL_INT(ret_val_int)    return

I noticed that too after comparing GDAL shapelib with standalone shapelib. CPL_IGNORE_RET_VAL_INT is used only once, so I have already replaced in r69892

    CPL_IGNORE_RET_VAL_INT(DBFFlushRecord( psDBF ));

with

    DBFFlushRecord( psDBF );

as in standalone shapelib. Thanks for reviewing the changes!

[neteler]

The new SHAPELIB 1.4 version is out:

​http://lists.maptools.org/pipermail/shapelib/2016-December/000631.html

Time to resync fixes into GRASS GIS or can we get rid of this clone?

[martinl]

Status of this issue is not clear.

[neteler]

Ticket retargeted after milestone closed

[mmetz]

Milestone for this ticket should always be trunk.

[martinl]

Ticket retargeted after milestone closed

[martinl]

Ticket retargeted after milestone closed

[sbl]

Maybe time to drop DBF as supported DB backend in GRASS 8/7.10?