Opened 16 years ago
Closed 8 years ago
#307 closed enhancement (fixed)
v.in.dxf: output name should be required
Reported by: | msieczka | Owned by: | |
---|---|---|---|
Priority: | trivial | Milestone: | 7.0.5 |
Component: | Vector | Version: | svn-trunk |
Keywords: | import | Cc: | martinl |
CPU: | All | Platform: | All |
Description
All import modules require an output map name. Why is v.in.dxf and exception and has it optional?
Change History (7)
follow-up: 2 comment:1 by , 16 years ago
Cc: | added |
---|
comment:2 by , 16 years ago
Replying to martinl:
Name of output vector map can be determined from input file name, e.g. file.dxf become 'file' vector map if output parameter is not given.
It was changed in GRASS7 where output is required. I would suggest leave v.in.dxf in GRASS6 as it is.
Agree re: GRASS6, just for compatibility's sake.
For 7.x, I have removed this kind of "magic" behaviour whenever I have encountered it. Apart from anything else, it means that the overwrite check has to be performed manually, rather than letting G_parser() do it.
It's worse for modules which create new maps (import and analysis). E.g. it might be desired to add an option to the GUI to automatically add newly-created maps to the map display. Obviously that can only work if the GUI knows that a map has been created, and what it's called.
follow-up: 5 comment:3 by , 16 years ago
Keywords: | import added |
---|---|
Type: | defect → enhancement |
v.in.ogr can do the same -- it will automatically set the output name from the layer name if it is not given. IMO it is a really nice time (and typo) saving feature and I'd be sad to see it go.
Hamish
comment:4 by , 16 years ago
Priority: | major → trivial |
---|
comment:5 by , 15 years ago
Milestone: | 6.4.0 → 7.0.0 |
---|---|
Version: | svn-develbranch6 → svn-trunk |
Replying to hamish:
v.in.ogr can do the same -- it will automatically set the output name from the layer name if it is not given. IMO it is a really nice time (and typo) saving feature and I'd be sad to see it go.
Do you think to make 'output' optional in v.in.dxf again?
comment:6 by , 8 years ago
Milestone: | 7.0.0 → 7.0.5 |
---|
comment:7 by , 8 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
output name is already required in G70
Name of output vector map can be determined from input file name, e.g. file.dxf become 'file' vector map if output parameter is not given.
It was changed in GRASS7 where output is required. I would suggest leave v.in.dxf in GRASS6 as it is.